Merge branch 'master' into augmented-memo-docs

Author: akelad

.travis.yml

@@ -59,6 +59,7 @@ jobs:
   - stage: test
     name: "Test Docs"
     install:
+    - pip install -r requirements.txt
     - pip install -r requirements-docs.txt
     - pip install -e .[sql]
     - pip list
@@ -72,6 +73,7 @@ jobs:
     - RASABASTER=rasabaster-0.7.23.tar.gz
     - curl -sSL -o $RASABASTER "https://storage.googleapis.com/docs-theme/${RASABASTER}?q=$(date +%s%N)"
     - pip install $RASABASTER
+    - pip install -r requirements.txt
     - pip install --no-cache-dir -r requirements-docs.txt
     - pip install git+https://${GITHUB_TOKEN}:[email protected]/RasaHQ/sphinxcontrib-versioning.git@version_list
     - pip install -e .

CHANGELOG.rst

@@ -13,11 +13,16 @@ This project adheres to `Semantic Versioning`_ starting with version 1.0.
 
 Added
 -----
+- Added data validator that checks if domain object returned is empty. If so, exit early from the command ``rasa data validate``
 - Added the KeywordIntentClassifier
 - Added documentation for ``AugmentedMemoizationPolicy``
+- Fall back to ``InMemoryTrackerStore`` in case there is any problem with the current
+  tracker store
 
 Changed
 -------
+- Do not retrain the entire Core model if only the ``templates`` section of the domain is changed.
+- Upgraded ``jsonschema`` version
 
 Removed
 -------
@@ -229,7 +234,6 @@ Changed
 -------
 - Pin gast to == 0.2.2
 
-
 [1.3.0] - 2019-09-05
 ^^^^^^^^^^^^^^^^^^^^
 

docs/user-guide/validate-files.rst

@@ -41,6 +41,8 @@ actions.
 
 **verify_all():** Runs all verifications above.
 
+**verify_domain_validity():** Check if domain is valid.
+
 To use these functions it is necessary to create a `Validator` object and initialize the logger. See the following code:
 
 .. code-block:: python

rasa/cli/data.py

@@ -103,5 +103,9 @@ def validate_files(args):
     )
 
     validator = loop.run_until_complete(Validator.from_importer(file_importer))
+    domain_is_valid = validator.verify_domain_validity()
+    if not domain_is_valid:
+        sys.exit(1)
+
     everything_is_alright = validator.verify_all(not args.fail_on_warnings)
     sys.exit(0) if everything_is_alright else sys.exit(1)

rasa/cli/x.py

@@ -347,7 +347,7 @@ def run_in_production(args: argparse.Namespace):
 
 
 def _get_credentials_and_endpoints_paths(
-    args: argparse.Namespace
+    args: argparse.Namespace,
 ) -> Tuple[Optional[Text], Optional[Text]]:
     config_endpoint = args.config_endpoint
     if config_endpoint:

rasa/constants.py

@@ -9,6 +9,7 @@
 DEFAULT_DATA_PATH = "data"
 DEFAULT_RESULTS_PATH = "results"
 DEFAULT_NLU_RESULTS_PATH = "nlu_comparison_results"
+DEFAULT_CORE_SUBDIRECTORY_NAME = "core"
 DEFAULT_REQUEST_TIMEOUT = 60 * 5  # 5 minutes
 
 TEST_DATA_FILE = "test.md"

rasa/core/agent.py

@@ -12,7 +12,12 @@
 import rasa
 import rasa.utils.io
 import rasa.core.utils
-from rasa.constants import DEFAULT_DOMAIN_PATH, LEGACY_DOCS_BASE_URL, ENV_SANIC_BACKLOG
+from rasa.constants import (
+    DEFAULT_DOMAIN_PATH,
+    LEGACY_DOCS_BASE_URL,
+    ENV_SANIC_BACKLOG,
+    DEFAULT_CORE_SUBDIRECTORY_NAME,
+)
 from rasa.core import constants, jobs, training
 from rasa.core.channels.channel import InputChannel, OutputChannel, UserMessage
 from rasa.core.constants import DEFAULT_REQUEST_TIMEOUT
@@ -25,7 +30,11 @@
 from rasa.core.policies.memoization import MemoizationPolicy
 from rasa.core.policies.policy import Policy
 from rasa.core.processor import MessageProcessor
-from rasa.core.tracker_store import InMemoryTrackerStore, TrackerStore
+from rasa.core.tracker_store import (
+    InMemoryTrackerStore,
+    TrackerStore,
+    FailSafeTrackerStore,
+)
 from rasa.core.trackers import DialogueStateTracker
 from rasa.exceptions import ModelNotFound
 from rasa.importers.importer import TrainingDataImporter
@@ -764,8 +773,8 @@ def persist(self, model_path: Text, dump_flattened_stories: bool = False) -> Non
         if not self.is_core_ready():
             raise AgentNotReady("Can't persist without a policy ensemble.")
 
-        if not model_path.endswith("core"):
-            model_path = os.path.join(model_path, "core")
+        if not model_path.endswith(DEFAULT_CORE_SUBDIRECTORY_NAME):
+            model_path = os.path.join(model_path, DEFAULT_CORE_SUBDIRECTORY_NAME)
 
         self._clear_model_directory(model_path)
 
@@ -851,9 +860,11 @@ def create_tracker_store(
     ) -> TrackerStore:
         if store is not None:
             store.domain = domain
-            return store
+            tracker_store = store
         else:
-            return InMemoryTrackerStore(domain)
+            tracker_store = InMemoryTrackerStore(domain)
+
+        return FailSafeTrackerStore(tracker_store)
 
     @staticmethod
     def _create_lock_store(store: Optional[LockStore]) -> LockStore:

rasa/core/brokers/utils.py

@@ -14,7 +14,7 @@
 
 
 def from_endpoint_config(
-    broker_config: Optional[EndpointConfig]
+    broker_config: Optional[EndpointConfig],
 ) -> Optional["EventChannel"]:
     """Instantiate an event channel based on its configuration."""
 
@@ -41,7 +41,7 @@ def from_endpoint_config(
 
 
 def load_event_channel_from_module_string(
-    broker_config: EndpointConfig
+    broker_config: EndpointConfig,
 ) -> Optional["EventChannel"]:
     """Instantiate an event channel based on its class name."""
 
@@ -57,7 +57,7 @@ def load_event_channel_from_module_string(
 
 
 def create_rabbitmq_ssl_options(
-    rabbitmq_host: Optional[Text] = None
+    rabbitmq_host: Optional[Text] = None,
 ) -> Optional["pika.SSLOptions"]:
     """Create RabbitMQ SSL options.
 

rasa/core/domain.py

@@ -3,6 +3,7 @@
 import logging
 import os
 import typing
+from pathlib import Path
 from typing import Any, Dict, List, Optional, Text, Tuple, Union, Set
 
 import rasa.core.constants
@@ -664,7 +665,7 @@ def as_dict(self) -> Dict[Text, Any]:
             "forms": self.form_names,
         }
 
-    def persist(self, filename: Text) -> None:
+    def persist(self, filename: Union[Text, Path]) -> None:
         """Write domain to a file."""
 
         domain_data = self.as_dict()

rasa/core/interpreter.py

@@ -135,7 +135,7 @@ def _starts_with_intent_prefix(self, text: Text) -> bool:
 
     @staticmethod
     def extract_intent_and_entities(
-        user_input: Text
+        user_input: Text,
     ) -> Tuple[Optional[Text], float, List[Dict[Text, Any]]]:
         """Parse the user input using regexes to extract intent & entities."""