Merge branch 'master' of github.com:RasaHQ/rasa into convert_feat

Author: dakshvar22

CHANGELOG.rst

@@ -38,7 +38,8 @@ Fixed
 - Fixed server hanging forever on leaving ``rasa shell`` before first message
 - Fixed rasa init showing traceback error when user does Keyboard Interrupt before choosing a project path
 - ``CountVectorsFeaturizer`` featurizes intents only if its analyzer is set to ``word``
-- fixed bug where facebooks generic template was not rendered when buttons were ``None``
+- Fixed bug where facebooks generic template was not rendered when buttons were ``None``
+- Fixed default intents unnecessarily raising undefined parsing error
 
 [1.4.5] - 2019-11-14
 ^^^^^^^^^^^^^^^^^^^^

rasa/core/processor.py

@@ -20,6 +20,8 @@
     ACTION_NAME_SENDER_ID_CONNECTOR_STR,
     USER_INTENT_RESTART,
     UTTER_PREFIX,
+    USER_INTENT_BACK,
+    USER_INTENT_OUT_OF_SCOPE,
 )
 from rasa.core.domain import Domain
 from rasa.core.events import (
@@ -289,17 +291,28 @@ def _log_slots(tracker):
             logger.debug(f"Current slot values: \n{slot_values}")
 
     def _log_unseen_features(self, parse_data: Dict[Text, Any]) -> None:
-        """Check if the NLU interpreter picks up intents or entities that aren't in the domain."""
+        """Check if the NLU interpreter picks up intents or entities that aren't recognized."""
 
         domain_is_not_empty = self.domain and not self.domain.is_empty()
+
+        default_intents = [
+            USER_INTENT_RESTART,
+            USER_INTENT_BACK,
+            USER_INTENT_OUT_OF_SCOPE,
+        ]
+
         intent = parse_data["intent"]["name"]
-        if intent and domain_is_not_empty and intent not in self.domain.intents:
-            warnings.warn(
-                f"Interpreter parsed an intent '{intent}' "
-                "that is not defined in the domain."
-            )
+        if intent:
+            intent_is_recognized = (
+                domain_is_not_empty and intent in self.domain.intents
+            ) or intent in default_intents
+            if not intent_is_recognized:
+                warnings.warn(
+                    f"Interpreter parsed an intent '{intent}' "
+                    "that is not defined in the domain."
+                )
 
-        entities = parse_data["entities"]
+        entities = parse_data["entities"] or []
         for element in entities:
             entity = element["entity"]
             if entity and domain_is_not_empty and entity not in self.domain.entities:

tests/core/test_processor.py

@@ -83,6 +83,14 @@ async def test_log_unseen_feature(default_processor: MessageProcessor):
     )
 
 
+async def test_default_intent_recognized(default_processor: MessageProcessor):
+    message = UserMessage("/restart")
+    parsed = await default_processor._parse_message(message)
+    with pytest.warns(None) as record:
+        default_processor._log_unseen_features(parsed)
+    assert len(record) == 0
+
+
 async def test_http_parsing():
     message = UserMessage("lunch?")