Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL3, macOS: SDL_tray.h missing from framework bundle #11760

Closed
andreasgrabher opened this issue Dec 28, 2024 · 5 comments
Closed

SDL3, macOS: SDL_tray.h missing from framework bundle #11760

andreasgrabher opened this issue Dec 28, 2024 · 5 comments
Assignees
@slouken
Milestone
3.2.0

Comments

@andreasgrabher
Copy link

I think the title says it all.
@madebr
Copy link
Contributor

madebr commented Dec 28, 2024

Indeed, dmg verification fails: https://github.com/madebr/SDL/actions/runs/12527498042/job/34941166857#step:6:71

@slouken
Copy link
Collaborator

slouken commented Dec 28, 2024

I'll fix this.

@slouken slouken added this to the 3.2.0 milestone Dec 28, 2024
@slouken slouken self-assigned this Dec 28, 2024
@sezero
Copy link
Contributor

sezero commented Dec 28, 2024

CI failing:

CpHeader /Users/runner/work/SDL/SDL/Xcode/SDL/build/Release/SDL3.framework/Versions/A/Headers/SDL_tray.h /Users/runner/work/SDL/SDL/include/SDL_tray.h (in target 'SDL3' from project 'SDL')
    cd /Users/runner/work/SDL/SDL/Xcode/SDL
    builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -strip-unsigned-binaries -strip-deterministic -strip-tool /Applications/Xcode_15.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -resolve-src-symlinks /Users/runner/work/SDL/SDL/include/SDL_tray.h /Users/runner/work/SDL/SDL/Xcode/SDL/build/Release/SDL3.framework/Versions/A/Headers
error: /Users/runner/work/SDL/SDL/include/SDL_tray.h: No such file or directory (in target 'SDL3' from project 'SDL')

@slouken
Copy link
Collaborator

slouken commented Dec 28, 2024

Fixing...

@slouken slouken reopened this Dec 28, 2024
@slouken
Copy link
Collaborator

slouken commented Dec 28, 2024 •
edited
Loading

Okay, this should be fixed in c714b1a

@slouken slouken closed this as completed Dec 28, 2024
thatcosmonaut pushed a commit to thatcosmonaut/SDL that referenced this issue Jan 13, 2025
@slouken @thatcosmonaut
Add SDL_tray.h to the public framework headers
dffb988 
Fixes libsdl-org#11760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slouken slouken

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@slouken @madebr @sezero @andreasgrabher