From 20d598dfbcc2144ee3285ed16b7576a3c6cf09f3 Mon Sep 17 00:00:00 2001 From: Tal Safran Date: Tue, 7 Aug 2018 16:20:48 +0200 Subject: [PATCH 1/4] Make section selection a little more clear --- .github/PULL_REQUEST_TEMPLATE.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index bab75e5aa52..69c5c215a80 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,11 +7,10 @@ - [ ] Suggesting edits to an existing topic or collection - [ ] Curating a new topic or collection - ---------------------------------------------------------------------- - +--------------------------------------------------------------------- + ### Editing an existing topic or collection I'm suggesting these edits to an existing topic or collection: @@ -21,6 +20,8 @@ I'm suggesting these edits to an existing topic or collection: Please explain why these changes are necessary: + + ### Curating a new topic or collection - [ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. `https://github.com/topics/[NAME]` or `https://github.com/collections/[NAME]`) From 5f28d2a0e0992a2bd6f9f488d42a67d202da6d51 Mon Sep 17 00:00:00 2001 From: Tal Safran Date: Tue, 7 Aug 2018 16:21:15 +0200 Subject: [PATCH 2/4] Make change reason question pop out more --- .github/PULL_REQUEST_TEMPLATE.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 69c5c215a80..e64cbfc3f48 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,8 +17,9 @@ I'm suggesting these edits to an existing topic or collection: - [ ] Image (and my file is `*.png`, square, dimensions 288x288) - [ ] Content (and my changes are in `index.md`) -Please explain why these changes are necessary: +**Please explain why these changes are necessary:** + @@ -28,7 +29,9 @@ Please explain why these changes are necessary: - [ ] My folder contains a `*.png` image (if applicable) and `index.md` - [ ] All required fields in my `index.md` conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs -Please explain why you think this topic or collection should be curated: +**Please explain why you think this topic or collection should be curated:** + + --------------------------------------------------------------------- From 7ea974761c312d3c7fb2e0732038da0a9c0fffb0 Mon Sep 17 00:00:00 2001 From: Tal Safran Date: Tue, 7 Aug 2018 16:25:53 +0200 Subject: [PATCH 3/4] Use quote blocks instead of bold + comments This should make it easier for folks looking at the PR to tell if this section was provided. --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e64cbfc3f48..19281c1905d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,10 +17,7 @@ I'm suggesting these edits to an existing topic or collection: - [ ] Image (and my file is `*.png`, square, dimensions 288x288) - [ ] Content (and my changes are in `index.md`) -**Please explain why these changes are necessary:** - - - +> Please delete this line and explain why you think these changes should be made. ### Curating a new topic or collection @@ -29,10 +26,7 @@ I'm suggesting these edits to an existing topic or collection: - [ ] My folder contains a `*.png` image (if applicable) and `index.md` - [ ] All required fields in my `index.md` conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs -**Please explain why you think this topic or collection should be curated:** - - - +> Please delete this line and explain why you think this topic or collection should be curated. --------------------------------------------------------------------- From 441ddbd4f4baa00c1137e95d2e1498d7eaba8678 Mon Sep 17 00:00:00 2001 From: Tal Safran Date: Tue, 7 Aug 2018 17:26:09 +0200 Subject: [PATCH 4/4] Small copy tweak --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 19281c1905d..aec19bddb48 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,7 +17,7 @@ I'm suggesting these edits to an existing topic or collection: - [ ] Image (and my file is `*.png`, square, dimensions 288x288) - [ ] Content (and my changes are in `index.md`) -> Please delete this line and explain why you think these changes should be made. +> Please replace this line with an explanation of why you think these changes should be made. ### Curating a new topic or collection @@ -26,7 +26,7 @@ I'm suggesting these edits to an existing topic or collection: - [ ] My folder contains a `*.png` image (if applicable) and `index.md` - [ ] All required fields in my `index.md` conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs -> Please delete this line and explain why you think this topic or collection should be curated. +> Please replace this line with an explanation of why you think this topic or collection should be curated. ---------------------------------------------------------------------