Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ChainError Better #251

Open
TheBlueMatt opened this issue Nov 15, 2018 · 0 comments
Open

Document ChainError Better #251

TheBlueMatt opened this issue Nov 15, 2018 · 0 comments

Comments

@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Nov 15, 2018

From IRC:

<TamasBlummer> @BlueMatt: The SPV node I build in rust-bitcoin-spv would preferably store only a subset of the blockchain data, that concerns its own level1 or lightning wallet. How should it implement install_watch_tx (for the parameter txid) and get_chain_utxo? without full blockchain?
<BlueMatt> TamasBlummer: oops, should document that better, but you should return Err(ChainError::NotSupported)
<BlueMatt> https://docs.rs/lightning/0.0.6/lightning/chain/chaininterface/enum.ChainError.html
<BlueMatt> TamasBlummer: you can freely not support that function at all, or support it only partially, as you see fit

This should obviously be better documented so as to not result in questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant