Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a faster way of comparing #5

Open
RedyAu opened this issue Jan 12, 2021 · 1 comment
Open

Have a faster way of comparing #5

RedyAu opened this issue Jan 12, 2021 · 1 comment

Comments

@RedyAu
Copy link

RedyAu commented Jan 12, 2021

I'm very happy with this package, apart from its speed. It takes a while to get the differences.
I'm seeing percentages down to the billionth digit returned, this is totally unnecessary for me, it would be enough if it returned for example tenths only and was faster.
I have no idea if this would be even achievable without rewriting the whole thing, but it sure would be nice.
Also, I have a sneaky suspicion, that even if I request the percentage, the algorithm first generates the diff image, and gets the percentage from that. If this is the case, I don't know how, but it would be nice to get rid of the image generation too, when unnecessary.

@limonadev
Copy link
Owner

Hi! Could you share the images you are trying to compare? (And the times you are getting with them). This way I can try to optimize the code to improve the processing time based on your own benchmarks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants