Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Add external member #333

Open
BenoitTallandier opened this issue Oct 1, 2020 · 4 comments
Open

[Story] Add external member #333

BenoitTallandier opened this issue Oct 1, 2020 · 4 comments
Assignees
Labels

Comments

@BenoitTallandier
Copy link
Contributor

BenoitTallandier commented Oct 1, 2020

Epic #308

As a user, I can add an external member to the discussion channel (message activity is send in the channel).

To add external user into a channel:

  1. Click on "..." next to a channel and select "Manage channel guests"
  2. A dedicated modal opens to manage all guests in this channel
  3. We add a text input in which we can type an email, this email will be invited as guest and added in the guest list.

On the channel members list we see all members guest and non guests

  1. Guests channel members must have a visual "guest" tag
  2. Clicking on "..." next to a guest channel member in this modal shows "Manage channel guests" and redirect to the guest management modal.

Business case

  • Only paid company can invite guest user
  • user AND workspace moderator are able to invite guest inside the company

Tech

This story can be divided in this technical issues:

  • backend (php), add in the console API the ability to invite emails as guests
  • backend (node), add a table to keep track of the invited emails in each channels before they activate their account. Also create an endpoint to get list of pending guests emails.
  • backend (node), automatically add the guest into each channels he belongs to as soon as his account is created (console hook)
  • frontend, add the "guest" tag in the channel members modal and also in the workspace collaborators list view
  • frontend, create the new guest management modal and get list of pending and non-pending guest from backend
  • Define the user role in the company, workspace and its profile
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 24, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 24, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 24, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 24, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 25, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 25, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 25, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 25, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 25, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 1, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 1, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 1, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 1, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 1, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 1, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 1, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Apr 8, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue May 5, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue May 5, 2021
RomaricMourgues added a commit to stephanevieira75/Twake that referenced this issue May 5, 2021
RomaricMourgues added a commit that referenced this issue May 5, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* #333 Remove re-send invitation button in MemberChannelRow

* #333 Hide ChannelsApps when user is guest

* #333 Set firstName and lastName for pending emails

* #333 Add handler for NewPendingEmailsInWorkspaceJoinChannelsProcessor

* #333 Firstname and lastName fields should not be empty

* #333 Allow filtering channel members by role

* #333 Hide guest management popup when user is guest and add missing translations

* #333 Remove re-send invitation button in MemberChannelRow

* Fix channel visibility business rule

* #333 Update setGuests method in GuestManagementService

* #333 Update setGuests method in GuestManagementService

Co-authored-by: Romaric Mourgues <[email protected]>
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue May 5, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue May 5, 2021
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue May 5, 2021
RomaricMourgues pushed a commit that referenced this issue May 5, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…1247)

* #333 Fix search in Guest Management

* #333 Set member limit to 20 in ChannelMembersList

* #333 MemberChannelRow design improvements
RomaricMourgues pushed a commit that referenced this issue May 5, 2021
…1247)

* #333 Fix search in Guest Management

* #333 Set member limit to 20 in ChannelMembersList

* #333 MemberChannelRow design improvements
@tlle14
Copy link
Contributor

tlle14 commented May 11, 2021

Hi, I finish retesting the story:
- Need confirmation:

There doesn't have a button for the Guest to leave the channel by himself. Is this expected behavior? 

- Test result:

Total: 9 issues
Critical: 1
Major: 4
Medium: 3
Minor: 1

@BenoitTallandier @RomaricMourgues Please confirm the behavior
@hantt12 Please review the test result and correct me if there's something wrong.

Thanks!

@RomaricMourgues
Copy link
Contributor

RomaricMourgues commented May 11, 2021 via email

@chamerling chamerling self-assigned this Jun 22, 2021
@RomaricMourgues RomaricMourgues added this to the 2021.Q3 milestone Aug 3, 2021
@hantt12
Copy link

hantt12 commented Oct 28, 2021

Please check issue:
#1724
#1725
#1726

@hantt12
Copy link

hantt12 commented Oct 28, 2021

Discussion:
Currently I see that Guest has permission to remove other members from channel.
Imo, we should not allow guest to do this @RomaricMourgues

@RomaricMourgues RomaricMourgues modified the milestones: 2021.Q3, 2021.Q4 Nov 24, 2021
@BenoitTallandier BenoitTallandier removed this from the 2021.Q4 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants