Skip to content

Commit de0aca6

Browse files
committed
Build src/test/isolation during "make" and "make install".
This hack closes a race condition in "make -j check-world" and "make -j installcheck-world". Back-patch to v10, before which these parallel invocations had worse problems. Discussion: https://postgr.es/m/[email protected]
1 parent 2393194 commit de0aca6

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/Makefile

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ SUBDIRS = \
2828
pl \
2929
makefiles \
3030
test/regress \
31+
test/isolation \
3132
test/perl
3233

3334
# There are too many interdependencies between the subdirectories, so

src/test/isolation/Makefile

+7
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@ OBJS = specparse.o isolationtester.o $(WIN32RES)
1515

1616
all: isolationtester$(X) pg_isolation_regress$(X)
1717

18+
# Though we don't install these binaries, build them during installation
19+
# (including temp-install). Otherwise, "make -j check-world" and "make -j
20+
# installcheck-world" would spawn multiple, concurrent builds in this
21+
# directory. Later builds would overwrite files while earlier builds are
22+
# reading them, causing occasional failures.
23+
install: | all
24+
1825
submake-regress:
1926
$(MAKE) -C $(top_builddir)/src/test/regress pg_regress.o
2027

0 commit comments

Comments
 (0)