From f1790b745bc4f9aeaed9bfe777103bcd5561bddf Mon Sep 17 00:00:00 2001 From: Przemek Denkiewicz Date: Thu, 7 Aug 2025 15:51:29 +0200 Subject: [PATCH 1/5] Fix Snowflake coverage docs generation --- .github/workflows/update-snowflake-feature-coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-snowflake-feature-coverage.yml b/.github/workflows/update-snowflake-feature-coverage.yml index 03c0a8a..a6851f4 100644 --- a/.github/workflows/update-snowflake-feature-coverage.yml +++ b/.github/workflows/update-snowflake-feature-coverage.yml @@ -44,7 +44,7 @@ jobs: uses: peter-evans/create-pull-request@v7 if: ${{ success() && steps.check-for-changes.outputs.diff-count != '0' && steps.check-for-changes.outputs.diff-count != '' }} with: - path: src + path: localstack-docs title: "Update function coverage documentation" body: "Automated update of snowflake feature coverage docs" branch: "snowflake-feature-coverage-updates" From 2e138f774e36b3b660dd087dd7473905e9b9935d Mon Sep 17 00:00:00 2001 From: Przemek Denkiewicz Date: Thu, 7 Aug 2025 15:58:51 +0200 Subject: [PATCH 2/5] fix --- .../workflows/update-snowflake-feature-coverage.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/update-snowflake-feature-coverage.yml b/.github/workflows/update-snowflake-feature-coverage.yml index a6851f4..68f254f 100644 --- a/.github/workflows/update-snowflake-feature-coverage.yml +++ b/.github/workflows/update-snowflake-feature-coverage.yml @@ -40,6 +40,18 @@ jobs: mv coverage-features.md src/content/docs/snowflake/features/index.md mv coverage-functions.md src/content/docs/snowflake/sql-functions.md + - name: Check for changes + id: check-for-changes + working-directory: localstack-docs + run: | + # Check if there are changed files and store the result in resources/diff-check.log + # Check against the PR branch if it exists, otherwise against the main + # Store the result in resources/diff-check.log and store the diff count in the GitHub Action output "diff-count" + mkdir -p resources + (git diff --name-only origin/snowflake-feature-coverage-updates src/content/docs/snowflake/features/index.md src/content/docs/snowflake/sql-functions.md 2>/dev/null || git diff --name-only origin/${{ github.event.inputs.targetBranch || 'main' }} src/content/docs/snowflake/features/index.md src/content/docs/snowflake/sql-functions.md 2>/dev/null) | tee resources/diff-check.log + echo "diff-count=$(cat resources/diff-check.log | wc -l)" >> $GITHUB_OUTPUT + cat resources/diff-check.log + - name: Create PR uses: peter-evans/create-pull-request@v7 if: ${{ success() && steps.check-for-changes.outputs.diff-count != '0' && steps.check-for-changes.outputs.diff-count != '' }} From 79266f0caf9b512ddef8343d724e9f388e87360a Mon Sep 17 00:00:00 2001 From: Przemek Denkiewicz Date: Thu, 7 Aug 2025 16:03:10 +0200 Subject: [PATCH 3/5] fix --- .../workflows/update-snowflake-feature-coverage.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/update-snowflake-feature-coverage.yml b/.github/workflows/update-snowflake-feature-coverage.yml index 68f254f..b10244e 100644 --- a/.github/workflows/update-snowflake-feature-coverage.yml +++ b/.github/workflows/update-snowflake-feature-coverage.yml @@ -44,13 +44,12 @@ jobs: id: check-for-changes working-directory: localstack-docs run: | - # Check if there are changed files and store the result in resources/diff-check.log - # Check against the PR branch if it exists, otherwise against the main - # Store the result in resources/diff-check.log and store the diff count in the GitHub Action output "diff-count" - mkdir -p resources - (git diff --name-only origin/snowflake-feature-coverage-updates src/content/docs/snowflake/features/index.md src/content/docs/snowflake/sql-functions.md 2>/dev/null || git diff --name-only origin/${{ github.event.inputs.targetBranch || 'main' }} src/content/docs/snowflake/features/index.md src/content/docs/snowflake/sql-functions.md 2>/dev/null) | tee resources/diff-check.log - echo "diff-count=$(cat resources/diff-check.log | wc -l)" >> $GITHUB_OUTPUT - cat resources/diff-check.log + git add . + if git diff --staged --quiet; then + echo "diff-count=0" >> $GITHUB_OUTPUT + else + echo "diff-count=1" >> $GITHUB_OUTPUT + fi - name: Create PR uses: peter-evans/create-pull-request@v7 From 134f7124801bc44b44eced3d5e6f9d9f6c6e48fa Mon Sep 17 00:00:00 2001 From: Przemek Denkiewicz Date: Thu, 7 Aug 2025 16:08:02 +0200 Subject: [PATCH 4/5] fix --- .github/workflows/update-snowflake-feature-coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-snowflake-feature-coverage.yml b/.github/workflows/update-snowflake-feature-coverage.yml index b10244e..11869f6 100644 --- a/.github/workflows/update-snowflake-feature-coverage.yml +++ b/.github/workflows/update-snowflake-feature-coverage.yml @@ -63,4 +63,4 @@ jobs: committer: "LocalStack Bot " commit-message: "automated update of snowflake feature coverage docs" token: ${{ secrets.PRO_ACCESS_TOKEN }} - reviewers: hovaesco, harshcasper + reviewers: hovaesco From 1bf6e65f0a68e1b54f1e7a67032c62836db3ab78 Mon Sep 17 00:00:00 2001 From: Quetzalli Date: Thu, 7 Aug 2025 07:16:47 -0700 Subject: [PATCH 5/5] Update .github/workflows/update-snowflake-feature-coverage.yml --- .github/workflows/update-snowflake-feature-coverage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-snowflake-feature-coverage.yml b/.github/workflows/update-snowflake-feature-coverage.yml index 11869f6..aec4ee8 100644 --- a/.github/workflows/update-snowflake-feature-coverage.yml +++ b/.github/workflows/update-snowflake-feature-coverage.yml @@ -63,4 +63,4 @@ jobs: committer: "LocalStack Bot " commit-message: "automated update of snowflake feature coverage docs" token: ${{ secrets.PRO_ACCESS_TOKEN }} - reviewers: hovaesco + reviewers: hovaesco, quetzalliwrites