Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails after recent update #5

Closed
tmillenaar opened this issue Sep 5, 2024 · 4 comments
Closed

Build fails after recent update #5

tmillenaar opened this issue Sep 5, 2024 · 4 comments

Comments

@tmillenaar
Copy link

As of the merging of the following mr: #4, my Docker image fails to build.
Example of a failing build: https://git.astron.nl/ldv/lofar_quality/-/jobs/885091#L2891
Apparently it is related to casacore::CanonicalIO::CanonicalIO(std::shared_ptr<casacore::RegularFileIO>&)

It seems I am using casacore-dev amd64 3.4.0-2build1 in that build, I imagine based on the following casacore-dev dependency:
https://git.astron.nl/ldv/lofar_quality/-/blob/b57739e4f59938fa0cffde33037d46623ad541c4/docker/Dockerfile#L8

I get the feeling that the casacore and lofarstman versions I now install don't work together properly, though I beleive I pull both without version restriction. Could it maybe be that ubuntu 22 is restricting the casacore version from being up to date for example?

I can install a previous version of lofarstman, but I'd rater not pin on old versions if I can avoid it.

Any suggestions?

Cheers,
Timo

@tammojan
Copy link
Collaborator

tammojan commented Sep 5, 2024

Merging #4 was necessary to be compatible with the freshly released casacore 3.6.1.

We can fix the test to work also with casacore 3.4.0. The library itself builds and works with both casacore 3.4.0 and casacore 3.6.1.

@tmillenaar
Copy link
Author

I get my casacore using apt install casacore-dev. Could it be that the ubuntu repository is not fully up-to-date?
With the latest ubuntu I get version casacore version 3.5.0-4.1ubuntu2 and that one does not build either. See: https://launchpad.net/ubuntu/+source/casacore

@tammojan
Copy link
Collaborator

tammojan commented Sep 5, 2024

Ubuntu is certainly not up-to-date, but this should work on both old and new casacores.

@tammojan
Copy link
Collaborator

tammojan commented Sep 5, 2024

Should be fixed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants