Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block the Overflow #310

Open
raphael-arce opened this issue Sep 9, 2014 · 9 comments
Open

Block the Overflow #310

raphael-arce opened this issue Sep 9, 2014 · 9 comments

Comments

@raphael-arce
Copy link

Hello,

i'm trying to learn by myself webdesign and english is not my main language, so please excuse my bad english/explanation of my issue. After adding the Lightbox2 to my website, i observed that it is possible to scroll when the lightbox is open. How could you block the scrolling (i think it is named the overflow) when the lightbox ist open ?

Thanks for the great work,
Greetings,
Multiflux

@kafeltz
Copy link

kafeltz commented Sep 9, 2014

Good question. This could be a nice feature to add-on.

@matheuslc
Copy link

So, the user has to close the modal for have scroll again?

@raphael-arce
Copy link
Author

Yes, kind of "locking" the screen while the lightbox is open.

@matheuslc
Copy link

I understand. Add another option, like, "noScroll" and If this option is true, we block the scroll, if isn't, stay unblocked. What's you think?

@matheuslc
Copy link

@Multiflux I made this option, can you test? * I made a pull request, but you can test now downloading from my fork.

@raphael-arce
Copy link
Author

Exactly what i've searched for. Great work !
Thank you very much.

@matheuslc
Copy link

@Multiflux I'm glad for that, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@lokesh @kafeltz @matheuslc @raphael-arce and others