Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve task data visualization #275

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Conversation

lucafaggianelli
Copy link
Owner


if not data:
if not data_file.exists():

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
.
This path depends on a
user-provided value
.
raise HTTPException(status_code=404, detail="Task has no data")

return data
return FileResponse(path=data_file, filename=f"run-{run_id}-{task}-data.json")

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
.
This path depends on a
user-provided value
.

logs_file = get_logs_filename(pipeline_run_id)

if not logs_file.exists():

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
.

# Create all parent directories without raising errors
# equivalent to mkdir -p
data_path.parent.mkdir(parents=True, exist_ok=True)

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
.
This path depends on a
user-provided value
.
This path depends on a
user-provided value
.
return

with file.open(mode="r", encoding="utf-8") as f:
return json.load(f)
with logs_file.open(mode="r", encoding="utf-8") as f:

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
.
@lucafaggianelli lucafaggianelli merged commit 6d5f155 into main Nov 3, 2023
6 of 7 checks passed
@lucafaggianelli lucafaggianelli deleted the feature/task-data-view branch November 3, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant