Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method size_t LiquidCrystal_I2C::write() does not return a value #4

Open
grmcdorman opened this issue Jan 3, 2022 · 0 comments
Open

Comments

@grmcdorman
Copy link

inline size_t LiquidCrystal_I2C::write(uint8_t value) {
	send(value, Rs);
}

Missing return value. This is an error and can fail builds if warnings-as-errors is turned on for this issue. I believe this can also cause resets or other undefined behaviour if code tries to use the non-existent return value.

The method signature either needs a return type of void, or the method needs to return a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant