Skip to content

Commit 1676e43

Browse files
committed
Fix brin regression test so it actually tests cidr.
The problem noted in my previous commit was simpler than I thought: we weren't getting an index plan because the column wasn't indexed.
1 parent 79454c6 commit 1676e43

File tree

2 files changed

+4
-28
lines changed

2 files changed

+4
-28
lines changed

src/test/regress/expected/brin.out

+2-28
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ CREATE INDEX brinidx ON brintest USING brin (
7777
macaddrcol,
7878
inetcol inet_inclusion_ops,
7979
inetcol inet_minmax_ops,
80+
cidrcol inet_inclusion_ops,
81+
cidrcol inet_minmax_ops,
8082
bpcharcol,
8183
datecol,
8284
timecol,
@@ -373,34 +375,6 @@ BEGIN
373375
END LOOP;
374376
END;
375377
$x$;
376-
WARNING: did not get bitmap indexscan plan for (cidrcol,&&,inet,10/8,100)
377-
WARNING: did not get bitmap indexscan plan for (cidrcol,=,inet,10.2.14/24,2)
378-
WARNING: did not get bitmap indexscan plan for (cidrcol,<,inet,255.255.255.255,100)
379-
WARNING: did not get bitmap indexscan plan for (cidrcol,<=,inet,255.255.255.255,100)
380-
WARNING: did not get bitmap indexscan plan for (cidrcol,>,inet,0.0.0.0,125)
381-
WARNING: did not get bitmap indexscan plan for (cidrcol,>=,inet,0.0.0.0,125)
382-
WARNING: did not get bitmap indexscan plan for (cidrcol,>>=,inet,10.2.14.231/24,2)
383-
WARNING: did not get bitmap indexscan plan for (cidrcol,>>,inet,10.2.14.231/25,2)
384-
WARNING: did not get bitmap indexscan plan for (cidrcol,<<=,inet,10.2.14.231/8,100)
385-
WARNING: did not get bitmap indexscan plan for (cidrcol,<<,inet,0/0,100)
386-
WARNING: did not get bitmap indexscan plan for (cidrcol,&&,inet,fe80::6e40:8ff:fea9:a673/32,25)
387-
WARNING: did not get bitmap indexscan plan for (cidrcol,>>=,inet,fe80::6e40:8ff:fea9:8c46,1)
388-
WARNING: did not get bitmap indexscan plan for (cidrcol,<<=,inet,fe80::6e40:8ff:fea9:a673/32,25)
389-
WARNING: did not get bitmap indexscan plan for (cidrcol,=,inet,fe80::6e40:8ff:fea9:8c46,1)
390-
WARNING: did not get bitmap indexscan plan for (cidrcol,&&,cidr,10/8,100)
391-
WARNING: did not get bitmap indexscan plan for (cidrcol,=,cidr,10.2.14/24,2)
392-
WARNING: did not get bitmap indexscan plan for (cidrcol,<,cidr,255.255.255.255,100)
393-
WARNING: did not get bitmap indexscan plan for (cidrcol,<=,cidr,255.255.255.255,100)
394-
WARNING: did not get bitmap indexscan plan for (cidrcol,>,cidr,0.0.0.0,125)
395-
WARNING: did not get bitmap indexscan plan for (cidrcol,>=,cidr,0.0.0.0,125)
396-
WARNING: did not get bitmap indexscan plan for (cidrcol,>>=,cidr,10.2.14/24,2)
397-
WARNING: did not get bitmap indexscan plan for (cidrcol,>>,cidr,10.2.14/25,2)
398-
WARNING: did not get bitmap indexscan plan for (cidrcol,<<=,cidr,10/8,100)
399-
WARNING: did not get bitmap indexscan plan for (cidrcol,<<,cidr,0/0,100)
400-
WARNING: did not get bitmap indexscan plan for (cidrcol,&&,cidr,fe80::/32,25)
401-
WARNING: did not get bitmap indexscan plan for (cidrcol,>>=,cidr,fe80::6e40:8ff:fea9:8c46,1)
402-
WARNING: did not get bitmap indexscan plan for (cidrcol,<<=,cidr,fe80::/32,25)
403-
WARNING: did not get bitmap indexscan plan for (cidrcol,=,cidr,fe80::6e40:8ff:fea9:8c46,1)
404378
INSERT INTO brintest SELECT
405379
repeat(stringu1, 42)::bytea,
406380
substr(stringu1, 1, 1)::"char",

src/test/regress/sql/brin.sql

+2
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ CREATE INDEX brinidx ON brintest USING brin (
8080
macaddrcol,
8181
inetcol inet_inclusion_ops,
8282
inetcol inet_minmax_ops,
83+
cidrcol inet_inclusion_ops,
84+
cidrcol inet_minmax_ops,
8385
bpcharcol,
8486
datecol,
8587
timecol,

0 commit comments

Comments
 (0)