Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download files with common prefix ("folder") #16

Open
henrikskog opened this issue Jul 13, 2024 · 3 comments
Open

Download files with common prefix ("folder") #16

henrikskog opened this issue Jul 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@henrikskog
Copy link
Contributor

I use s3 for backups, where I structure the backups using prefixes. It would be cool to be able to download a given backup.

@lusingander
Copy link
Owner

When displaying a list of files, are you envisioning a feature like "Save recursively" that allows all files under a specific path to be downloaded together?

I agree that this feature is important for this application.

Here are some concerns that have been hindering the implementation:

  • Since the file size could become large, we need to ensure proper progress display and the ability to cancel the operation appropriately.
  • There could be many requests in a short period, so it is necessary to manage requests properly.
  • To prevent unintended operations, it might be better to show a confirmation dialog.
    • Currently, the application does not have a confirmation dialog implementation.
    • It might be necessary to display the number of target files and the total size beforehand.

@lusingander lusingander added the enhancement New feature or request label Jul 14, 2024
@henrikskog
Copy link
Contributor Author

When displaying a list of files, are you envisioning a feature like "Save recursively" that allows all files under a specific path to be downloaded together?

Yes!

I see your concerns! Ratatui probably has some confirmation dialog.

@lusingander
Copy link
Owner

In reality, the implementation of dialog itself is not particularly difficult.
The true challenge in TUI applications lies in determining the appropriate implementation approach, as the way widgets are displayed and interacted with can vary greatly depending on the nature of the application and the developer's perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants