Fix style and misleading comments/log in RPL/uIP

Author: arurke

os/net/ipv6/uip6.c

@@ -1250,7 +1250,7 @@ uip_process(uint8_t flag)
         goto send;
       }
 
-      LOG_INFO("Forwarding packet to next hop ");
+      LOG_INFO("Forwarding packet to next hop, dest: ");
       LOG_INFO_6ADDR(&UIP_IP_BUF->destipaddr);
       LOG_INFO_("\n");
       UIP_STAT(++uip_stat.ip.forwarded);
@@ -1368,7 +1368,7 @@ uip_process(uint8_t flag)
             goto send;
           }
 
-          LOG_INFO("Forwarding packet to next hop ");
+          LOG_INFO("Forwarding packet to next hop, dest: ");
           LOG_INFO_6ADDR(&UIP_IP_BUF->destipaddr);
           LOG_INFO_("\n");
           UIP_STAT(++uip_stat.ip.forwarded);

os/net/routing/routing.h

@@ -94,7 +94,7 @@ struct routing_driver {
    * \param node The source routing node
    * \return 1 if the global node address was copied, 0 otherwise
   */
-  int (* get_sr_node_ipaddr)(uip_ipaddr_t *addr, const uip_sr_node_t *node);
+  int (* get_sr_node_ipaddr)(uip_ipaddr_t *ipaddr, const uip_sr_node_t *node);
   /**
    * Leave the network the node is part of
    *
@@ -171,9 +171,7 @@ struct routing_driver {
   /**
    * Called by uIP to notify addition/removal of IPv6 neighbor entries
    *
-   * \param addr The link-layer addrress of the packet destination
-   * \param status The transmission status (see os/net/mac/mac.h)
-   * \param numtx The total number of transmission attempts
+   * \param nbr The neighbor entry
    */
   void (* neighbor_state_changed)(uip_ds6_nbr_t *nbr);
   /**

os/net/routing/rpl-classic/rpl-dag.c

@@ -1423,7 +1423,8 @@ rpl_process_parent_event(rpl_instance_t *instance, rpl_parent_t *p)
   if(RPL_IS_STORING(instance)
      && uip_ds6_route_is_nexthop(rpl_parent_get_ipaddr(p))
      && !rpl_parent_is_reachable(p) && instance->mop > RPL_MOP_NON_STORING) {
-    LOG_WARN("Unacceptable link %u, removing routes via: ", rpl_get_parent_link_metric(p));
+    LOG_WARN("Unacceptable link %u, removing routes via: ",
+             rpl_get_parent_link_metric(p));
     LOG_WARN_6ADDR(rpl_parent_get_ipaddr(p));
     LOG_WARN_("\n");
     rpl_remove_routes_by_nexthop(rpl_parent_get_ipaddr(p), p->dag);

os/net/routing/rpl-classic/rpl-mrhof.c

@@ -65,7 +65,7 @@
  * result, MRHOF will favor good links over short paths. Without this
  * feature, a hop with 50% PRR (ETX=2) is equivalent to two perfect
  * hops with 100% PRR (ETX=1+1=2). With this feature, the former path
- * obtains ETX=2*2=4 and the former ETX=1*1+1*1=2.
+ * obtains ETX=2*2=4 and the latter ETX=1*1+1*1=2.
  *
  * While this feature helps achieve extra reliability, it also results
  * in added churn. In networks with high congestion or poor links,