From 99d0a0142e7dea786f202048ed40392dffdad337 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Proch=C3=A1zka?= <honza.spacir@gmail.com>
Date: Fri, 12 Apr 2024 14:32:37 +0200
Subject: [PATCH] Full check 8 (#5956)

<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

A comment in bash still counts as a line, so in

```bash
asdf \
  --test \
  # comment
  --foo
```

`--foo` is treated as a separate command

### Checklist
* [ ] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [ ] I've included a screenshot or gif (if applicable)
* [ ] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [ ] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [ ] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
---
 .github/workflows/on_pr_comment.yml | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/on_pr_comment.yml b/.github/workflows/on_pr_comment.yml
index 600b7dbd12f6..92f3bbcc9173 100644
--- a/.github/workflows/on_pr_comment.yml
+++ b/.github/workflows/on_pr_comment.yml
@@ -53,11 +53,11 @@ jobs:
             local created_after=$3
             echo $(
               # https://cli.github.com/manual/gh_run_list
+              # https://docs.github.com/en/search-github/getting-started-with-searching-on-github/understanding-the-search-syntax#query-for-dates
               gh run list \
                 --workflow $workflow_name \
                 --event workflow_dispatch \
                 --branch $ref_name \
-                # https://docs.github.com/en/search-github/getting-started-with-searching-on-github/understanding-the-search-syntax#query-for-dates
                 --created ">$created_after" \
                 --json databaseId
             )
@@ -83,14 +83,10 @@ jobs:
           # started a workflow in parallel with us on the same branch.
 
           echo "Fetching workflow run id…"
-          run_info=$(get_latest_workflow_run $workflow_name $ref_name $now)
-          echo $run_info
-          run_id=$(echo $run_info | jq -r '.[0].databaseId')
+          run_id=$(get_latest_workflow_run $workflow_name $ref_name $now | jq -r '.[0].databaseId')
           while [ -z $run_id ]
           do
-            run_info=$(get_latest_workflow_run $workflow_name $ref_name $now)
-            echo $run_info
-            run_id=$(echo $run_info | jq -r '.[0].databaseId')
+            run_id=$(get_latest_workflow_run $workflow_name $ref_name $now | jq -r '.[0].databaseId')
             sleep 1
           done
           echo "Workflow run: https://github.com/rerun-io/rerun/actions/runs/$run_id"