-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make R.swift faster on big projects or string files #479
Comments
@marekpridal: Do you use the I added some logging into RswiftCore.run to have a quick look at the issue and got the following:
In my case, the following line takes 36 seconds to run: let ignoreFile = (try? IgnoreFile(ignoreFileURL: callInformation.rswiftIgnoreURL)) ?? IgnoreFile() My ignore file looks like the following:
Would be good to know if our performance issues are related or not |
Great work and yes I did! We use it a lot because we use R framework basically only for localizables 👍🏻🙂 |
Looks like we're on the same page then... I've dug into it a bit and it seems like the root cause is in I don't really know much about all of this but after Googling "glob", I found this doc that says the following:
I guess it makes sense, our repo is large so there are a lot of directories to check.. Changing my
@marekpridal: Let me know if you are able to do the same and if you experience similar results. I guess this might not actually be an issue but instead maybe could come under a basic troubleshooting tip or something? Ps: Running |
Faced this issue also. With just one line https://github.com/mac-cain13/R.swift/blob/master/Documentation/Ignoring.md |
To whomever is reading this, I found the LE: More about the |
Split off from comment #456 (comment)
R.swift takes 20 seconds to run on a 3000 line strings file. Or 30 seconds to run on a big project.
If anyone has example projects or files they could share, that would be great to reproduce the issue and figure out where the bottleneck is.
/cc @marekpridal @liamnichols
The text was updated successfully, but these errors were encountered: