@@ -584,8 +584,6 @@ ExecHashTableCreate(HashState *state, List *hashOperators, bool keepNulls)
584
584
hashtable -> shared -> size = bytes ;
585
585
hashtable -> shared -> nbatch = hashtable -> nbatch ;
586
586
587
- /* TODO: ExecHashBuildSkewHash */
588
-
589
587
/*
590
588
* The backend-local pointers in hashtable will be set up by
591
589
* ExecHashUpdate, at each point where they might have
@@ -938,8 +936,6 @@ ExecHashIncreaseNumBatches(HashJoinTable hashtable, int nbatch)
938
936
MemoryContextSwitchTo (oldcxt );
939
937
940
938
hashtable -> nbatch = nbatch ;
941
-
942
- /* TODO: If know we need to resize nbuckets, we can do it while rebatching. */
943
939
}
944
940
945
941
/*
@@ -986,9 +982,10 @@ ExecHashShrink(HashJoinTable hashtable)
986
982
{
987
983
/* Serial phase: one participant clears the hash table. */
988
984
/*
989
- * TODO: Also expland the bucket array if nbuckets_optimal >
990
- * nbuckets (but nbuckets_optional may need to be halved, to
991
- * account for the shink we're about to perform!)
985
+ * We could also expland the bucket array if nbuckets_optimal >
986
+ * nbuckets (if we do that we need to remember that
987
+ * nbuckets_optional may need to be halved, to account for the
988
+ * shink we're about to perform).
992
989
*/
993
990
memset (hashtable -> buckets , 0 ,
994
991
hashtable -> nbuckets * sizeof (HashJoinBucketHead ));
0 commit comments