Skip to content

Commit b87db0c

Browse files
author
Thomas Munro
committed
Remove junk
1 parent 3e06694 commit b87db0c

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/backend/executor/nodeHash.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -584,8 +584,6 @@ ExecHashTableCreate(HashState *state, List *hashOperators, bool keepNulls)
584584
hashtable->shared->size = bytes;
585585
hashtable->shared->nbatch = hashtable->nbatch;
586586

587-
/* TODO: ExecHashBuildSkewHash */
588-
589587
/*
590588
* The backend-local pointers in hashtable will be set up by
591589
* ExecHashUpdate, at each point where they might have
@@ -938,8 +936,6 @@ ExecHashIncreaseNumBatches(HashJoinTable hashtable, int nbatch)
938936
MemoryContextSwitchTo(oldcxt);
939937

940938
hashtable->nbatch = nbatch;
941-
942-
/* TODO: If know we need to resize nbuckets, we can do it while rebatching. */
943939
}
944940

945941
/*
@@ -986,9 +982,10 @@ ExecHashShrink(HashJoinTable hashtable)
986982
{
987983
/* Serial phase: one participant clears the hash table. */
988984
/*
989-
* TODO: Also expland the bucket array if nbuckets_optimal >
990-
* nbuckets (but nbuckets_optional may need to be halved, to
991-
* account for the shink we're about to perform!)
985+
* We could also expland the bucket array if nbuckets_optimal >
986+
* nbuckets (if we do that we need to remember that
987+
* nbuckets_optional may need to be halved, to account for the
988+
* shink we're about to perform).
992989
*/
993990
memset(hashtable->buckets, 0,
994991
hashtable->nbuckets * sizeof(HashJoinBucketHead));

0 commit comments

Comments
 (0)