Bug: test/test_Signal.py:51: AssertionError 162 != 161 with Python 3.7 & MACS 2.2.5

[mr-c]

Thanks for the new release with all the tests!

Describe the bug
Build time test failure

To Reproduce

python3.7 -m pytest test

Expected behavior
No failed tests

Screenshots

I: pybuild base:217: cd /build/macs-2.2.5/.pybuild/cpython3_3.7_MACS2/build; python3.7 -m pytest test
============================= test session starts ==============================
platform linux -- Python 3.7.5, pytest-4.6.6, py-1.8.0, pluggy-0.13.0

[…]

=================================== FAILURES ===================================
___________________________ Test_maxima.test_maxima ____________________________

self = <test_Signal.Test_maxima testMethod=test_maxima>

    def test_maxima(self):
        expect = self.summit
        result = maxima( self.signal, self.windowsize )[0]
>       self.assertEqual( result, expect )
E       AssertionError: 162 != 161

test/test_Signal.py:51: AssertionError
----------------------------- Captured stdout call -----------------------------
[0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 4. 4. 4. 4.
 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 5. 5. 5. 5. 5. 5. 5. 5. 5.
 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5. 5.
 5. 5. 5. 5. 5. 5. 5. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6.
 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 7. 7. 7.
 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7.
 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 6. 6. 6. 7. 7. 7. 7. 7. 7. 7. 7.
 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7.
 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 7. 8. 8. 8. 8.
 8. 8. 8. 8. 8. 8. 7. 7. 7. 7. 7. 7. 7. 7. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6.
 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 6. 4. 4. 4. 4. 4.
 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4.
 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4. 4.
 4. 4. 4. 4. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3.
 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3.
 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3.
 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3.
 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3. 3.
 3. 3. 3. 3. 3. 3.]

System (please complete the following information):

• OS: Debian Linux "sid"
• Python version 3.7.5
• Numpy version 1.16.5-1
• MACS Version 2.2.5

Additional context
Add any other context about the problem here.

[taoliu]

Hi @mr-c I know it's quite strange but Numpy 1.16 failed the test, and if you switch to Numpy 1.17 the unit test will pass. See my previous commit 2c8f14b. Don't have time to figure out why...

[mr-c]

Thanks @taoliu

I found this while packaging the latest release of MACS for Debian. Alas Debian doesn't have 1.17 yet, just 1.16.5

https://tracker.debian.org/pkg/python-numpy

Shall I delay the new package of MACS until Debian gets numpy 1.17+?

[taoliu]

@mr-c Please delay. I think sid will soon pick up numpy1.17? But, it seems only 1.16.5 will be included in testing/Bullseye.

[mr-c]

Okay, happy to delay. Once numpy 1.17 passes the tests it will also migrate to testing/Bullseye

[mr-c]

With python3 numpy version 1.17.4 I still get the same error :-(

[taoliu]

@mr-c Strange! It can pass all the tests through Travis CI in the PR #345... as the configuration with .travis.yml and Travis CI report for this test. I used Python 3.7.5 and Numpy 1.17.4 the same as you mentioned. Do you mind to share some suggestions on how to replicate the error?

Currently, I am preparing the v2.2.6 release. But I am happy to delay the release until I can address the issue for Debian.