Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlibvc.vcxproj Debug x86 and Debug x64 targets do not build #377

Closed
levicki opened this issue Sep 5, 2018 · 1 comment
Closed

zlibvc.vcxproj Debug x86 and Debug x64 targets do not build #377

levicki opened this issue Sep 5, 2018 · 1 comment

Comments

@levicki
Copy link

levicki commented Sep 5, 2018

This issue is about contrib\vstudio\vc12\zlibvc.vcxproj project file for Visual Studio 2013,

Debug x86 does not build because of /SAFESEH option, and hand-written assembler code which is not written with safe exception handlers in mind. The build errors are as follows:

match686.obj : error LNK2026: module unsafe for SAFESEH image.
inffas32.obj : error LNK2026: module unsafe for SAFESEH image.
x86\ZlibDllDebug\zlibwapi.dll : fatal error LNK1281: Unable to generate SAFESEH image.

Release x86 is set to /SAFESEH:no so I assume it is OK to do the same for Debug build.

Debug x64 does not build because of wrong path in PreBuildEvent -- command is:

cd ..\..\contrib\masmx64

Instead of:

cd ..\..\masmx64

Wrong path in PreBuildEvent seems to have been introduced in vc11 and exists in vc11, vc12, and vc14 versions of zlibvc.vcxproj file.

Proposed patch to fix both Debug builds (for vc12 version only):
https://gist.github.com/levicki/813dd78a43b3aaf6faaf1ff710bc2753

@levicki
Copy link
Author

levicki commented Sep 5, 2018

There is already a pull request here, but only for VS 2015 (vc14):
#353

@levicki levicki closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant