Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.3 version is badly packaged in composer #3359

Open
giacmir opened this issue Aug 12, 2022 · 1 comment
Open

1.2.3 version is badly packaged in composer #3359

giacmir opened this issue Aug 12, 2022 · 1 comment

Comments

@giacmir
Copy link
Member

giacmir commented Aug 12, 2022

Summary (*)

After upgrading to Magento 2.4.5 my composer.lock indicates that I have installed version 1.2.3 of module-inventory-configurable-product

image

On github, looking at files for 1.2.3 tag, module directory /Plugin/CatalogInventory/ looks like this:

image

in my vendor directory the same directory looks like this:

image

As you can see what we have on github and what we have in the composer patches differs significantly (also... that file that is in the package but not on github has also a bug, and that's why I've discovered this misalignment).

Packaging automations (is exist) should ensure that the code that is packaged in composer is the same that we have on github at all times. Otherwise it will be impossible both to fix things and to be confident that what has been developed is the same product that will be shipped to the public.

@m2-assistant
Copy link

m2-assistant bot commented Aug 12, 2022

Hi @giacmir. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant