Cache Keys associated with FPC on Magento 2.4.7 multi-store implementations

[dandrikop]

Preconditions and environment

For Magento 2.4.7 multi-store implementations with the patch ACSD-62591 installed, the FPC is working. However, the naming convention of the Cache Keys does not seem to follow the pattern of Magento versions prior to 2.4.7.

Steps to reproduce

1. A Magento 2.4.7 multi-store implementation where the visitor is directed to the appropriate store via Apache .htaccess directives such as the following ones:

SetEnvIf Host www\.dlastore\.com MAGE_RUN_CODE=default
SetEnvIf Host www\.dlastore\.com MAGE_RUN_TYPE=store
SetEnvIf Host fr\.dlastore\.com MAGE_RUN_CODE=french_dla
SetEnvIf Host fr\.dlastore\.com MAGE_RUN_TYPE=store

2. The patch ACSD-62591 should be installed.
3. Visit a page of the store

Expected result

The name of the Cache Key for FPC should include the values of the environment variables MAGE_RUN_TYPE and MAGE_RUN_CODE. I provide below the Vary Data from a 3rd party module which shows the IDs of the FPC Cache Keys on Magento 2.4.6:

Actual result

The name of the Cache Key for FPC does not include the values of the environment parameters variables MAGE_RUN_TYPE and MAGE_RUN_CODE. I provide below the Vary Data from a 3rd party module which shows the IDs of the FPC Cache Keys on Magento 2.4.7:

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @dandrikop. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[dandrikop]

Hello @engcom-Hotel,

I opened this new issue as you recommended with the issue #39439. I would be grateful if you you could check this with priority, and if applicable provide a new version of the patch ACSD-62591 which initially fixed the issue with FPC on multi-store implementations with Magento 2.4.7. It seems that the performance of Magento 2.4.7 is noticeably better than Magento 2.4.6, but without having the FPC properly working, the upgrade to Magento 2.4.7 is risky. So, it is essential for store owners of Magento multi-store implementations that the FPC problem is fixed.

[GrassH]

Hello @engcom-Hotel,

I have confirmed this issue on 2.4.7-p3, and it has been fixed in the 2.4-develop branch (0324569).

@dandrikop You can create a patch based on this commit. I have verified that the patch is work fine:
https://github.com/magento/magento2/commit/0324569f10758c5be062bff23b066db8f0fb39fc.patch

39456.zip

Thanks

[dandrikop]

Hello @GrassH,

Thanks for your feedback. Are you going to publish a new version of the patch ACSD-62591, or a new patch at Quality Patches Tool below?

https://experienceleague.adobe.com/tools/commerce-quality-patches/index.html

There may be some store owners who have installed the patch ACSD-62591, and think that they have resolved the issue with FPC and multi-store implementations. Also, via the Quality Patches Tool, the store owners will keep a track on the patches they have already installed.

[dandrikop]

Hello @engcom-Hotel,

Are you going to publish a new version of the patch ACSD-62591, or a new patch at Quality Patches Tool below?

https://experienceleague.adobe.com/tools/commerce-quality-patches/index.html

There may be some store owners who have installed the patch ACSD-62591, and think that they have resolved the issue with FPC and multi-store implementations. Also, via the Quality Patches Tool, the store owners will keep a track on the patches they have already installed.

[dandrikop]

Hello @engcom-Hotel, @GrassH,

The issue with the FPC and multi-store implementations on Magento 2.4.7 was first reported in Github on 17-Apr (7 months ago) with the issue #38626 (@thlassche)

Initially, the above issue has not been handled at all; instead it has been planned to be fixed on Magento 2.4.8 as mentioned for AC-11819 at the below link:
https://experienceleague.adobe.com/en/docs/commerce-operations/release/notes/magento-open-source/2-4-8

Afterwards, the patch ACSD-62591 was issued for Magento 2.4.7, but it partially fixed the problem. Indeed, you have already verified that the Cache Keys associated with FPC did not include the environmental variables MAGE_RUN_TYPE and MAGE_RUN_CODE as it happens for Magento versions prior to 2.4.7 (@MartinL1983).

The issue with FPC and Magento multi-store implementations is a serious problem, as it definitely prevents store owners from upgrading to the version 2.4.7 which is the current stable Magento version. Disregarding version 2.4.7 and going for 2.4.8 is not a solution as 2.4.8 is not stable yet, while it may not be possible for every Magento implementation to go directly to 2.4.8 from 2.4.6 or even some older version. Indeed, many third party extensions still have defects with version 2.4.7, and as a result, vendors may need time to make them work on 2.4.8, as well.

So, let's provide a final solution to this issue with specific directions that should be followed on Magento 2.4.7:

• Maybe the patch ACSD-62591 should be updated accordingly, and any store owner who has installed it should first uninstall it, and install the updated version.
• Maybe a new patch should be issued which has the patch ACSD-62591 as a prerequisite.

In any case, I consider that there must be an official solution on this issue published at Quality Patches Tool below:
https://experienceleague.adobe.com/tools/commerce-quality-patches/index.html

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @dandrikop,

Thanks for reporting the new issue related to cache keys. Can you please show some light on the below points:

• Which 3rd party extension you have used to display the cache keys?
• The actual issue you are getting due to the change of cache keys(not including MAGE_RUN_TYPE and MAGE_RUN_CODE in the cache keys), this will help us in prioritising the issue.

Thanks