Paypal Braintree Core module compatibility issue with Magento v2.4.8-p1 and PHP 8.4.6

[baijuncybercom]

Preconditions and environment

• Magento v2.4.8-p1
• Install fresh Magento v2.4.8-p1
• PHP v8.4.6

Steps to reproduce

Steps to reproduce

Run bin/magento setup:upgrade after running the following error is thrown:

Deprecated Functionality: PayPal\Braintree\Gateway\Config\Config::__construct(): Implicitly marking parameter $methodCode as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/paypal/module-braintree-core/Gateway/Config/Config.php on line 76

Expected result

No errors

Actual result

Deprecated Functionality: PayPal\Braintree\Gateway\Config\Config::__construct(): Implicitly marking parameter $methodCode as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/paypal/module-braintree-core/Gateway/Config/Config.php on line 76

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @baijuncybercom. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[hostep]

What version of paypal/module-braintree-core have you got installed? When setting up a fresh Magento 2.4.8-p1 install, you'll get version 4.7.0 of that module installed. Maybe you still have an older version installed somehow?

In version 4.7.0, the code you refer to is correct, the type for $methodCode is explicitly nullable and shouldn't trigger that error, see:

    # in file vendor/paypal/module-braintree-core/Gateway/Config/Config.php

    ...

    public function __construct(
        ScopeConfigInterface $scopeConfig,
        StoreConfigResolver $storeConfigResolver,
        ?string $methodCode = null,
        string $pathPattern = self::DEFAULT_PATH_PATTERN,
        ?Json $serializer = null
    ) {

    ...

[engcom-November]

Hello @baijuncybercom ,

Thank you for report and collaboration,

We attempted to reproduce the issue in our latest version 2.4 develop and 2.4.8-p1 but were unable to reproduce it. Please find the attached screenshot for reference.

Steps to Reproduce:

• Setup 2.4.8-p1
• Run bin/magento setup:upgrade

We followed these steps and precondition but did not encounter any issues. Could you please recheck and let us know if we are missing any steps to reproduce this issue?

Therefore, we are marking this ticket as "Issue: Needs Update".

Thank you!