Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc]: The first component should be Hero Video Dialog after clicking components link #304

Closed
alamenai opened this issue Sep 7, 2024 · 1 comment
Closed

[Doc]: The first component should be Hero Video Dialog after clicking components link #304

alamenai opened this issue Sep 7, 2024 · 1 comment

Comments

@alamenai
Copy link
Contributor

alamenai commented Sep 7, 2024

Hi @dillionverma ,

After you added the HVD component, it seems you forgot to target it as the first component when the users click on the components link.

Current

Marquee

Expected

Hero Video Dialog
sanjay-mali added a commit to sanjay-mali/magicui that referenced this issue Sep 17, 2024
@sanjay-mali
fix(components): change the order of items
9a7ccf3 
Changed the order of component items to improve layout and usability.

Fixes magicuidesign#304
@sanjay-mali sanjay-mali mentioned this issue Sep 17, 2024
Closed
@sanjay-mali
Copy link
Contributor

Hey!
Can you review my pull request? I just changed the order of component items. If anything else, then tell me.
Thanks.

@alamenai alamenai changed the title [Doc]: The fist component should be Hero Video Dialog after clicking components link [Doc]: The first component should be Hero Video Dialog after clicking components link Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alamenai @sanjay-mali