Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShinyButton misses the default button props #443

Closed
alamenai opened this issue Dec 14, 2024 · 2 comments
Closed

ShinyButton misses the default button props #443

alamenai opened this issue Dec 14, 2024 · 2 comments

Comments

@alamenai
Copy link
Contributor

When I started using Shiny Button, and I wanted to add onClick event, I noticed it missed the default button props ( HMTLButtonProps ):

image

The props should inherit the button element interface with the custom props:

image

This was just a quick thought.

Like this, we can find the default props:

image

@itsarghyadas
Copy link
Collaborator

https://magicui.design/docs/components/shiny-button

Hey, I just checked this button component and it does give you access to all the props of a button so what is the issue again?

@dillionverma
Copy link
Collaborator

Hey! I would check the latest code as I think we addressed this :) Closing issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants