-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to fetch style.json from a url #1460
Comments
there was some discussion about that before in https://osmus.slack.com/archives/C0436FK28C9/p1698761198318819 I think mainly this code would need to be changed to read from a http url if the file started with http |
Hey thanks for the response. I don't have access to the osmus slack, so don't know what was discussed there, but I can implement this if no one has anything against it. That said, I suppose adding a fetch to this part of the code would require quite a bit of refactoring to make the |
I think a feature like this would be a good addition. There would be a few places that might need some check if the path is a http string. I had mentioned in the slack we were using isValidHttpUrl in utils.js in some places for the pmtiles urls. |
It would be nice to be able to define a stylesheet from a url in the configuration. I imagine it would look something like this in the config:
Would this be possible? I was thinking that the style could be fetched when the app is launched (or if the config is reloaded using SIGHUP). I could probably add this feature myself, but would like to get the opinion of any contributors first in case there is a good reason not to add this.
The text was updated successfully, but these errors were encountered: