Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit fails #87

Closed
esurov opened this issue May 7, 2023 · 2 comments
Closed

Commit fails #87

esurov opened this issue May 7, 2023 · 2 comments

Comments

@esurov
Copy link
Contributor

esurov commented May 7, 2023

Trying to commit php code to the repo fails with a PHP Deprecated

gene@Genes-MacBook-Air PHP-Antimalware-Scanner % git commit -m bin/build
Checking PHP Lint...
[Done] Operation completed!
PHP Deprecated:  Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/gene/Work/WordPress Antivirus Project/PHP-Antimalware-Scanner/bin/composer/vendor/symfony/console/Helper/HelperSet.php on line 112
@esurov
Copy link
Contributor Author

esurov commented May 7, 2023

I provided a PR to fix this: #89
Turns out the problem is old version of composer included into the project. Updating it from 2.0 to 2.2 resolved the issue.

Related issue, old composer didn't support new GitHub oauth tokens:
[UnexpectedValueException]
Your github oauth token for github.com contains invalid characters

Upgrading composer solved the problem:
https://nono.ma/github-oauth-token-for-github-com-contains-invalid-characters-on-composer-install

@esurov
Copy link
Contributor Author

esurov commented May 7, 2023

@marcocesarato thanks for merging my PR

@esurov esurov closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant