diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt index df55fbb1c..90683ae26 100644 --- a/CONTRIBUTORS.txt +++ b/CONTRIBUTORS.txt @@ -8,3 +8,4 @@ Lisa Bylund Sebastian Allard Jozef Raschmann Tor-Björn Holmström +Stephen Patches \ No newline at end of file diff --git a/Kentor.AuthServices.Tests/WebSSO/AuthServicesUrlsTests.cs b/Kentor.AuthServices.Tests/WebSSO/AuthServicesUrlsTests.cs index 732053eda..79a961db7 100644 --- a/Kentor.AuthServices.Tests/WebSSO/AuthServicesUrlsTests.cs +++ b/Kentor.AuthServices.Tests/WebSSO/AuthServicesUrlsTests.cs @@ -38,7 +38,7 @@ public void AuthServicesUrls_Ctor_NullCheckApplicationUrl() [TestMethod] public void AuthServicesUrls_Ctor_NullCheckModulePath() { - Action a = () => new AuthServicesUrls(new Uri("http://localhost"), (string)null); + Action a = () => new AuthServicesUrls(new Uri("http://localhost"), modulePath: null); a.ShouldThrow("modulePath"); } @@ -103,7 +103,7 @@ public void AuthServicesUrls_Ctor_AllowsNullAcs() [TestMethod] public void AuthServicesUrls_Ctor_NullCheckSignin() { - Action a = () => new AuthServicesUrls(new Uri("http://localhost/signin"), (Uri)null); + Action a = () => new AuthServicesUrls(new Uri("http://localhost/signin"), signInUrl: null); a.ShouldThrow("signInUrl"); } diff --git a/Kentor.AuthServices/WebSSO/AuthServicesUrls.cs b/Kentor.AuthServices/WebSSO/AuthServicesUrls.cs index eda767368..9bd00cb8d 100644 --- a/Kentor.AuthServices/WebSSO/AuthServicesUrls.cs +++ b/Kentor.AuthServices/WebSSO/AuthServicesUrls.cs @@ -39,7 +39,8 @@ public AuthServicesUrls(HttpRequestData request, ISPOptions spOptions) /// /// The full Url to the root of the application. /// Path of module, starting with / and ending without. - [System.Diagnostics.CodeAnalysis.SuppressMessage( "Microsoft.Design", "CA1057:StringUriOverloadsCallSystemUriOverloads" )] + [System.Diagnostics.CodeAnalysis.SuppressMessage( "Microsoft.Design", "CA1057:StringUriOverloadsCallSystemUriOverloads" + , Justification = "Incorrect warning. modulePath isn't a string representation of a Uri" )] public AuthServicesUrls(Uri applicationUrl, string modulePath) { if (applicationUrl == null)