Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: matestack/matestack-ui-vuejs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: matestack/matestack-ui-vuejs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
  • 11 commits
  • 33 files changed
  • 3 contributors

Commits on Mar 27, 2023

  1. Update Dockerfile dependencies for local development and CI (#4)

    * Update chromium, nss and add gcompat library
    
    * Update ci Dockerfiles with nss and chromium dependencies
    
    * Revert alpine distributions for Ruby 2.6 and 2.7 images
    
    * Correct syntax for version specifier
    
    * Update ci Dockerfiles and compose file
    
    * Update workflow file with new actions
    
    * Add docker-compose services for Ruby 3.2
    
    * Address PsychLoad error against Ruby's master branch
    
    Issue found here: rails/rails@1e56b1d
    
    Rails resolves this with Rails 7.0.2.4.
    
    * Update Rails version to ~> 7.0.4
    
    * Bump webpacker
    
    * Add Tests against Rails 6.1 with Ruby 3.1 and Ruby 3.2
    
    * Update bundler version and rspec-rails version
    
    * Update dependencies
    
    * Update documentation to reflect support for Rails/Ruby versions
    
    * Update local development Dockerfiles to Ruby 3.2
    
    * Update .ruby-version listed version
    aaron-contreras authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    3457264 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Emit Multiple Events with onclick component (#10)

    * [ISSUE-5] Add spec coverage for onclick component
    
    Sets up a spec coverage suite for the new multi-event emission
    behavior for the onclick component as well as a slight refactor of
    the existing specs.
    
    * [ISSUE-5] Add multi-event emission ability to onclick component
    
    Adds the multi-event emission ability to the onclick component, while
    abstracting this ability into a mixin that can be used by other
    components as well.
    
    * [ISSUE-5] Update documentation for the onclick event's API
    
    There was an outdated section that mentioned that event payload
    can't be bundled in with the emitted event. Updated
    this as it's part of the API already. Also, covered the multi-event
    emission feature that's being added.
    
    The new coverage is on both documentation and specs. Making sure that
    the uncovered symbol/string event name is documented properly, examples
    provided and an accompanying spec that demonstrates the expected behavior.
    aaron-contreras authored Mar 28, 2023
    Configuration menu
    Copy the full SHA
    5c3edd7 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. [ISSUE-6] Refactor the toggle component

    Updates the documentation with some less than clear text. Refactoring
    the specs for context clarity and better readability and documentation
    capabilities. As a side, refactored the internals of the toggle
    component's setup for cleanliness and code reuse of the already provided
    functionality in `mixin.js`.
    
    As an attempt to start "prettying-up" the dummy app, added a section
    specifically for testing and playing around with the toggle component.
    aaron-contreras committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    c5b15bd View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. [ISSUE-7] Demo desired API on the dummy app's layout

    In order to try out and demonstrate the desired behavior, added
    a set of emitting transition components on the dummy app's layout
    that is available for everyone to try out while developing.
    aaron-contreras committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    6b6d086 View commit details
    Browse the repository at this point in the history
  2. [ISSUE-7] Add specs to cover the desired behavior

    Making sure a clear and consistent test case is documented to which
    the new feature can be backed against.
    aaron-contreras committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    00eae8c View commit details
    Browse the repository at this point in the history
  3. [ISSUE-7] Update transition component's ability to emit a custom event

    Adding in the `emit` property as optional and forwarding it inside
    `vue_props`. On the flip-side within the VueJs component, using the
    `emitEvents` function defined in mixin.js as the standard.
    
    I'm favoring a convention where if we define `const self = this` inside
    a function, we use that as the reference to the component throughout
    the entire function instead of mixing and matching `self` and `this`
    interchangeably in a single method. I find this much clearer and
    helps to keep less context on top of mind while trying to grok a
    piece of code.
    aaron-contreras committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5363bd6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4b3702b View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Merge pull request #11 from matestack/issue-6/toggle-component-multi-…

    …event-listening
    
    Refactor/Improve documentation on the `toggle` component
    jonasjabari authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b7910e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Configuration menu
    Copy the full SHA
    537f841 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d6739e View commit details
    Browse the repository at this point in the history
  3. Merge pull request #12 from matestack/issue-7/transition-component-cu…

    …stom-multi-event-submission
    aaron-contreras authored Apr 19, 2023
    Configuration menu
    Copy the full SHA
    550514b View commit details
    Browse the repository at this point in the history
Loading