-
-
Notifications
You must be signed in to change notification settings - Fork 1
Comparing changes
Open a pull request
base repository: matestack/matestack-ui-vuejs
base: main
head repository: matestack/matestack-ui-vuejs
compare: develop
- 11 commits
- 33 files changed
- 3 contributors
Commits on Mar 27, 2023
-
Update Dockerfile dependencies for local development and CI (#4)
* Update chromium, nss and add gcompat library * Update ci Dockerfiles with nss and chromium dependencies * Revert alpine distributions for Ruby 2.6 and 2.7 images * Correct syntax for version specifier * Update ci Dockerfiles and compose file * Update workflow file with new actions * Add docker-compose services for Ruby 3.2 * Address PsychLoad error against Ruby's master branch Issue found here: rails/rails@1e56b1d Rails resolves this with Rails 7.0.2.4. * Update Rails version to ~> 7.0.4 * Bump webpacker * Add Tests against Rails 6.1 with Ruby 3.1 and Ruby 3.2 * Update bundler version and rspec-rails version * Update dependencies * Update documentation to reflect support for Rails/Ruby versions * Update local development Dockerfiles to Ruby 3.2 * Update .ruby-version listed version
Configuration menu - View commit details
-
Copy full SHA for 3457264 - Browse repository at this point
Copy the full SHA 3457264View commit details
Commits on Mar 28, 2023
-
Emit Multiple Events with
onclick
component (#10)* [ISSUE-5] Add spec coverage for onclick component Sets up a spec coverage suite for the new multi-event emission behavior for the onclick component as well as a slight refactor of the existing specs. * [ISSUE-5] Add multi-event emission ability to onclick component Adds the multi-event emission ability to the onclick component, while abstracting this ability into a mixin that can be used by other components as well. * [ISSUE-5] Update documentation for the onclick event's API There was an outdated section that mentioned that event payload can't be bundled in with the emitted event. Updated this as it's part of the API already. Also, covered the multi-event emission feature that's being added. The new coverage is on both documentation and specs. Making sure that the uncovered symbol/string event name is documented properly, examples provided and an accompanying spec that demonstrates the expected behavior.
Configuration menu - View commit details
-
Copy full SHA for 5c3edd7 - Browse repository at this point
Copy the full SHA 5c3edd7View commit details
Commits on Apr 1, 2023
-
[ISSUE-6] Refactor the toggle component
Updates the documentation with some less than clear text. Refactoring the specs for context clarity and better readability and documentation capabilities. As a side, refactored the internals of the toggle component's setup for cleanliness and code reuse of the already provided functionality in `mixin.js`. As an attempt to start "prettying-up" the dummy app, added a section specifically for testing and playing around with the toggle component.
Configuration menu - View commit details
-
Copy full SHA for c5b15bd - Browse repository at this point
Copy the full SHA c5b15bdView commit details
Commits on Apr 4, 2023
-
[ISSUE-7] Demo desired API on the dummy app's layout
In order to try out and demonstrate the desired behavior, added a set of emitting transition components on the dummy app's layout that is available for everyone to try out while developing.
Configuration menu - View commit details
-
Copy full SHA for 6b6d086 - Browse repository at this point
Copy the full SHA 6b6d086View commit details -
[ISSUE-7] Add specs to cover the desired behavior
Making sure a clear and consistent test case is documented to which the new feature can be backed against.
Configuration menu - View commit details
-
Copy full SHA for 00eae8c - Browse repository at this point
Copy the full SHA 00eae8cView commit details -
[ISSUE-7] Update transition component's ability to emit a custom event
Adding in the `emit` property as optional and forwarding it inside `vue_props`. On the flip-side within the VueJs component, using the `emitEvents` function defined in mixin.js as the standard. I'm favoring a convention where if we define `const self = this` inside a function, we use that as the reference to the component throughout the entire function instead of mixing and matching `self` and `this` interchangeably in a single method. I find this much clearer and helps to keep less context on top of mind while trying to grok a piece of code.
Configuration menu - View commit details
-
Copy full SHA for 5363bd6 - Browse repository at this point
Copy the full SHA 5363bd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b3702b - Browse repository at this point
Copy the full SHA 4b3702bView commit details
Commits on Apr 18, 2023
-
Merge pull request #11 from matestack/issue-6/toggle-component-multi-…
…event-listening Refactor/Improve documentation on the `toggle` component
Configuration menu - View commit details
-
Copy full SHA for b7910e6 - Browse repository at this point
Copy the full SHA b7910e6View commit details
Commits on Apr 19, 2023
-
Merge branch 'develop' into issue-7/transition-component-custom-multi…
…-event-submission
Configuration menu - View commit details
-
Copy full SHA for 537f841 - Browse repository at this point
Copy the full SHA 537f841View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d6739e - Browse repository at this point
Copy the full SHA 3d6739eView commit details -
Merge pull request #12 from matestack/issue-7/transition-component-cu…
…stom-multi-event-submission
Configuration menu - View commit details
-
Copy full SHA for 550514b - Browse repository at this point
Copy the full SHA 550514bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...develop