Skip to content

Commit 0370c68

Browse files
committed
Merge remote-tracking branch 'origin/main' into testing
2 parents e491073 + 3c486fc commit 0370c68

File tree

6 files changed

+32
-3
lines changed

6 files changed

+32
-3
lines changed

.github/workflows/build_and_test_full.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ jobs:
4040
- name: Install MATLAB
4141
uses: matlab-actions/setup-matlab@v2
4242
with:
43+
release: R2025a
4344
products: MATLAB_Compiler MATLAB_Compiler_SDK
4445
- name: Build OpenTelemetry-Matlab
4546
working-directory: opentelemetry-matlab
@@ -70,6 +71,7 @@ jobs:
7071
- name: Install MATLAB
7172
uses: matlab-actions/setup-matlab@v2
7273
with:
74+
release: R2025a
7375
products: MATLAB_Compiler MATLAB_Compiler_SDK
7476
- name: Build OpenTelemetry-Matlab
7577
working-directory: opentelemetry-matlab
@@ -106,6 +108,8 @@ jobs:
106108
- name: Install MATLAB
107109
uses: matlab-actions/setup-matlab@v2
108110
with:
111+
# pin to R2024b because R2025a has an issue that causes a failure when building the context_propagation example
112+
release: R2024b
109113
products: MATLAB_Compiler MATLAB_Compiler_SDK
110114
- name: Build OpenTelemetry-Matlab
111115
working-directory: opentelemetry-matlab
@@ -140,6 +144,7 @@ jobs:
140144
- name: Install MATLAB
141145
uses: matlab-actions/setup-matlab@v2
142146
with:
147+
release: R2025a
143148
products: MATLAB_Compiler MATLAB_Compiler_SDK
144149
- name: Build OpenTelemetry-Matlab
145150
working-directory: opentelemetry-matlab

.github/workflows/build_and_test_simple.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ jobs:
4141
- name: Install MATLAB
4242
uses: matlab-actions/setup-matlab@v2
4343
with:
44+
release: R2025a
4445
products: MATLAB_Compiler MATLAB_Compiler_SDK
4546
- name: Build OpenTelemetry-Matlab
4647
working-directory: opentelemetry-matlab
@@ -70,6 +71,8 @@ jobs:
7071
- name: Install MATLAB
7172
uses: matlab-actions/setup-matlab@v2
7273
with:
74+
# pin to R2024b because R2025a has an issue that causes a failure when building the context_propagation example
75+
release: R2024b
7376
products: MATLAB_Compiler MATLAB_Compiler_SDK
7477
- name: Build OpenTelemetry-Matlab
7578
working-directory: opentelemetry-matlab
@@ -104,6 +107,7 @@ jobs:
104107
- name: Install MATLAB
105108
uses: matlab-actions/setup-matlab@v2
106109
with:
110+
release: R2025a
107111
products: MATLAB_Compiler MATLAB_Compiler_SDK
108112
- name: Build OpenTelemetry-Matlab
109113
working-directory: opentelemetry-matlab

.github/workflows/create_release.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
- name: Install MATLAB
1919
uses: matlab-actions/setup-matlab@v2
2020
with:
21+
release: R2025a
2122
products: MATLAB_Compiler
2223
- name: Build OpenTelemetry-Matlab
2324
working-directory: opentelemetry-matlab
@@ -46,6 +47,7 @@ jobs:
4647
- name: Install MATLAB
4748
uses: matlab-actions/setup-matlab@v2
4849
with:
50+
release: R2025a
4951
products: MATLAB_Compiler
5052
- name: Build OpenTelemetry-Matlab
5153
working-directory: opentelemetry-matlab
@@ -79,6 +81,7 @@ jobs:
7981
- name: Install MATLAB
8082
uses: matlab-actions/setup-matlab@v2
8183
with:
84+
release: R2025a
8285
products: MATLAB_Compiler
8386
- name: Build OpenTelemetry-Matlab
8487
working-directory: opentelemetry-matlab
@@ -121,7 +124,9 @@ jobs:
121124
tar -xzvf otel-matlab-macos-14.tar.gz
122125
tar -xzvf otel-matlab-windows.tar.gz
123126
- name: Install MATLAB
124-
uses: matlab-actions/setup-matlab@v1
127+
uses: matlab-actions/setup-matlab@v2
128+
with:
129+
release: R2025a
125130
- name: Run commands
126131
env:
127132
MATLABPATH: OpenTelemetry-Matlab/tools

CMakeLists.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ else()
2828

2929
set(VCPKG_FETCH_CONTENT_NAME vcpkg)
3030
set(VCPKG_GIT_REPOSITORY "https://github.com/microsoft/vcpkg.git")
31-
set(VCPKG_GIT_TAG "f7423ee")
31+
set(VCPKG_GIT_TAG "b02e341")
3232
FetchContent_Declare(
3333
${VCPKG_FETCH_CONTENT_NAME}
3434
GIT_REPOSITORY ${VCPKG_GIT_REPOSITORY}
@@ -56,7 +56,11 @@ if(APPLE)
5656
# use libcurl as a shared library and load the MATLAB version at runtime
5757
# run uname -m to determine whether arm64 or x86_64
5858
exec_program(uname ARGS -m OUTPUT_VARIABLE MAC_HOST_SYSTEM)
59-
set(VCPKG_OTEL_TRIPLET ${MAC_HOST_SYSTEM}-osx-otel-matlab)
59+
if(${MAC_HOST_SYSTEM} STREQUAL "arm64")
60+
set(VCPKG_OTEL_TRIPLET "arm64-osx-otel-matlab")
61+
elseif(${MAC_HOST_SYSTEM} STREQUAL "x86_64")
62+
set(VCPKG_OTEL_TRIPLET "x64-osx-otel-matlab")
63+
endif()
6064
set(VCPKG_OVERLAY_TRIPLETS ${CMAKE_SOURCE_DIR}/cmake/vcpkg_triplets)
6165
set(VCPKG_TARGET_TRIPLET ${VCPKG_OTEL_TRIPLET})
6266
set(TRIPLET_DEFINITIONS -DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET})

cmake/vcpkg_triplets/arm64-osx-otel-matlab.cmake

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ if(${PORT} MATCHES "(curl|zlib)")
55
else()
66
set(VCPKG_LIBRARY_LINKAGE static)
77
endif()
8+
# disable the script to fix rpath for curl, which makes an undesirable change to
9+
# the install name from @rpath/libcurl.4.dylib to @rpath/libcurl.4.8.0.dylib
10+
if(${PORT} MATCHES "curl")
11+
set(VCPKG_FIXUP_MACHO_RPATH OFF)
12+
endif()
13+
814

915
set(VCPKG_CMAKE_SYSTEM_NAME Darwin)
1016
set(VCPKG_OSX_ARCHITECTURES arm64)

cmake/vcpkg_triplets/x86_64-osx-otel-matlab.cmake renamed to cmake/vcpkg_triplets/x64-osx-otel-matlab.cmake

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ if(${PORT} MATCHES "(curl|zlib)")
55
else()
66
set(VCPKG_LIBRARY_LINKAGE static)
77
endif()
8+
# disable the script to fix rpath for curl, which makes an undesirable change to
9+
# the install name from @rpath/libcurl.4.dylib to @rpath/libcurl.4.8.0.dylib
10+
if(${PORT} MATCHES "curl")
11+
set(VCPKG_FIXUP_MACHO_RPATH OFF)
12+
endif()
813

914
set(VCPKG_CMAKE_SYSTEM_NAME Darwin)
1015
set(VCPKG_OSX_ARCHITECTURES x86_64)

0 commit comments

Comments
 (0)