From ffaf3b6fd8ac4580ce216b7e375b875f95bf1a01 Mon Sep 17 00:00:00 2001 From: duncanpo Date: Tue, 23 Sep 2025 15:13:14 -0400 Subject: [PATCH 1/9] debug upb build failure on mac --- .github/workflows/mac_upb_debug.yml | 39 +++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 .github/workflows/mac_upb_debug.yml diff --git a/.github/workflows/mac_upb_debug.yml b/.github/workflows/mac_upb_debug.yml new file mode 100644 index 0000000..a2f27f2 --- /dev/null +++ b/.github/workflows/mac_upb_debug.yml @@ -0,0 +1,39 @@ +name: "Debug Mac upb build failure" +on: + workflow_dispatch: + push: + branches: + - mac_upb_debug +env: + MLM_LICENSE_TOKEN: ${{ secrets.MLM_LICENSE_TOKEN }} +jobs: + build-and-run-tests-macos: + runs-on: macos-14 + needs: get_version + env: + OPENTELEMETRY_MATLAB_INSTALL: "${{ github.workspace }}/otel_matlab_install" + steps: + - name: Download OpenTelemetry-Matlab source + uses: actions/checkout@v3 + with: + path: opentelemetry-matlab + - name: Install ninja-build + run: brew install ninja + - name: Install MATLAB + uses: matlab-actions/setup-matlab@v2 + with: + release: R2025a + products: MATLAB_Compiler MATLAB_Compiler_SDK + - name: Build OpenTelemetry-Matlab + working-directory: opentelemetry-matlab + run: | + cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DWITH_OTLP_GRPC=ON -DUSE_BATCH_FOR_MCC=ON -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + cmake --build build --config Release --target install + - name: Run tests + env: + # Add the installation directory to the MATLAB Search Path by + # setting the MATLABPATH environment variable. + MATLABPATH: ${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + uses: matlab-actions/run-tests@v2 + with: + select-by-folder: opentelemetry-matlab/test From 28f2081a50648ef73ebe741b22a4a8f54ac63323 Mon Sep 17 00:00:00 2001 From: duncanpo Date: Tue, 23 Sep 2025 15:14:48 -0400 Subject: [PATCH 2/9] debug upb build failure on mac --- .github/workflows/mac_upb_debug.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/mac_upb_debug.yml b/.github/workflows/mac_upb_debug.yml index a2f27f2..6aba156 100644 --- a/.github/workflows/mac_upb_debug.yml +++ b/.github/workflows/mac_upb_debug.yml @@ -9,7 +9,6 @@ env: jobs: build-and-run-tests-macos: runs-on: macos-14 - needs: get_version env: OPENTELEMETRY_MATLAB_INSTALL: "${{ github.workspace }}/otel_matlab_install" steps: From f8d6bdf72981aa4b265dda311d83b226d98a8d68 Mon Sep 17 00:00:00 2001 From: duncanpo Date: Tue, 23 Sep 2025 15:16:39 -0400 Subject: [PATCH 3/9] debug upb build failure on mac --- .github/workflows/mac_upb_debug.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mac_upb_debug.yml b/.github/workflows/mac_upb_debug.yml index 6aba156..bef94b4 100644 --- a/.github/workflows/mac_upb_debug.yml +++ b/.github/workflows/mac_upb_debug.yml @@ -3,7 +3,7 @@ on: workflow_dispatch: push: branches: - - mac_upb_debug + - mac_upb env: MLM_LICENSE_TOKEN: ${{ secrets.MLM_LICENSE_TOKEN }} jobs: From 48c1cc25745827edbf1edf8736b003dd36a5bfe3 Mon Sep 17 00:00:00 2001 From: duncanpo Date: Tue, 23 Sep 2025 15:45:51 -0400 Subject: [PATCH 4/9] debug upb build failure on mac --- .github/workflows/mac_upb_debug.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/mac_upb_debug.yml b/.github/workflows/mac_upb_debug.yml index bef94b4..29ec891 100644 --- a/.github/workflows/mac_upb_debug.yml +++ b/.github/workflows/mac_upb_debug.yml @@ -36,3 +36,13 @@ jobs: uses: matlab-actions/run-tests@v2 with: select-by-folder: opentelemetry-matlab/test + - name: Compress test results into single artifact + if: always() + working-directory: ${{ github.workspace }} + run: tar -czf upb_failure_logs.tar.gz /Users/runner/work/OpenTelemetry-MATLAB/OpenTelemetry-MATLAB/opentelemetry-matlab/build/_deps/vcpkg-src/buildtrees/upb/ + - name: Upload artifacts + if: always() + uses: actions/upload-artifact@v4 + with: + name: upb_failure_logs.tar.gz + path: ${{ github.workspace }}/upb_failure_logs.tar.gz From 0efdd8e28d5e3cd8c6943ba1569235dd6e7d8142 Mon Sep 17 00:00:00 2001 From: duncanpo Date: Tue, 23 Sep 2025 17:01:31 -0400 Subject: [PATCH 5/9] debug workflow --- .github/workflows/mac_upb_debug.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mac_upb_debug.yml b/.github/workflows/mac_upb_debug.yml index 29ec891..5ac4cd1 100644 --- a/.github/workflows/mac_upb_debug.yml +++ b/.github/workflows/mac_upb_debug.yml @@ -26,7 +26,7 @@ jobs: - name: Build OpenTelemetry-Matlab working-directory: opentelemetry-matlab run: | - cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DWITH_OTLP_GRPC=ON -DUSE_BATCH_FOR_MCC=ON -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DWITH_OTLP_GRPC=ON -DUSE_BATCH_FOR_MCC=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} cmake --build build --config Release --target install - name: Run tests env: From d06c40f6cac9d786a53988d00240fed5fbb07afe Mon Sep 17 00:00:00 2001 From: duncanpo Date: Tue, 23 Sep 2025 18:06:06 -0400 Subject: [PATCH 6/9] debug workflow --- .github/workflows/mac_upb_debug.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/mac_upb_debug.yml b/.github/workflows/mac_upb_debug.yml index 5ac4cd1..8c98b2a 100644 --- a/.github/workflows/mac_upb_debug.yml +++ b/.github/workflows/mac_upb_debug.yml @@ -25,8 +25,10 @@ jobs: products: MATLAB_Compiler MATLAB_Compiler_SDK - name: Build OpenTelemetry-Matlab working-directory: opentelemetry-matlab + env: + CMAKE_POLICY_VERSION_MINIMUM: 3.5 run: | - cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DWITH_OTLP_GRPC=ON -DUSE_BATCH_FOR_MCC=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} + cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWITH_EXAMPLES=ON -DWITH_OTLP_GRPC=ON -DUSE_BATCH_FOR_MCC=ON -DCMAKE_INSTALL_PREFIX=${{ env.OPENTELEMETRY_MATLAB_INSTALL }} cmake --build build --config Release --target install - name: Run tests env: From 6d4d5aa5dcf918a7a6bb8faf971b944788cce05d Mon Sep 17 00:00:00 2001 From: duncanpo Date: Tue, 23 Sep 2025 18:30:57 -0400 Subject: [PATCH 7/9] debug workflow --- .github/workflows/mac_upb_debug.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mac_upb_debug.yml b/.github/workflows/mac_upb_debug.yml index 8c98b2a..385aaf5 100644 --- a/.github/workflows/mac_upb_debug.yml +++ b/.github/workflows/mac_upb_debug.yml @@ -41,7 +41,7 @@ jobs: - name: Compress test results into single artifact if: always() working-directory: ${{ github.workspace }} - run: tar -czf upb_failure_logs.tar.gz /Users/runner/work/OpenTelemetry-MATLAB/OpenTelemetry-MATLAB/opentelemetry-matlab/build/_deps/vcpkg-src/buildtrees/upb/ + run: tar -czf upb_failure_logs.tar.gz /Users/runner/work/OpenTelemetry-MATLAB/OpenTelemetry-MATLAB/opentelemetry-matlab/build/_deps/vcpkg-src/buildtrees/openssl/ - name: Upload artifacts if: always() uses: actions/upload-artifact@v4 From 6c6af7c4a7522fb411e42f93ac5007a85f8e6226 Mon Sep 17 00:00:00 2001 From: duncanpo Date: Wed, 24 Sep 2025 10:11:40 -0400 Subject: [PATCH 8/9] try a newer version of OpenSSL --- vcpkg.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vcpkg.json b/vcpkg.json index a295500..95e04f2 100644 --- a/vcpkg.json +++ b/vcpkg.json @@ -20,7 +20,10 @@ "abseil", "c-ares", "re2", - "openssl", + { + "name": "openssl", + "version>=": "3.5.0" + }, "upb" ] } From 8035234db921c3c40d6fd13e4812dadb720c5a54 Mon Sep 17 00:00:00 2001 From: duncanpo Date: Wed, 24 Sep 2025 10:26:24 -0400 Subject: [PATCH 9/9] bump up vcpkg version --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e02c2c9..04b78cc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -28,7 +28,7 @@ else() set(VCPKG_FETCH_CONTENT_NAME vcpkg) set(VCPKG_GIT_REPOSITORY "https://github.com/microsoft/vcpkg.git") - set(VCPKG_GIT_TAG "b02e341") + set(VCPKG_GIT_TAG "ce613c4") FetchContent_Declare( ${VCPKG_FETCH_CONTENT_NAME} GIT_REPOSITORY ${VCPKG_GIT_REPOSITORY}