Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"NickName has quit: Input/output error" do not get mapped to leave events #497

Open
pksadiq opened this issue Aug 28, 2017 · 12 comments
Open
Labels
needs-investigation T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@pksadiq
Copy link

pksadiq commented Aug 28, 2017

Keeping the offline IRC user in the user list results in lots of duplicates. Say for example My IRC nick is listed as pksadiq, pksadiq_, pksadiq__ and so on (when seen in RIOT web client).

So instead of keeping all those (duplicate) nicks. It would be nice if the nick is removed from the list once the user is quit, which means that all the listed IRC users is online (may be with away status).

Riot client gives tab completion for users that are offline too (as matrix users can set their status to offline). This would also be a help there.

Thanks

@t3chguy
Copy link
Member

t3chguy commented Aug 28, 2017

As I told you in #riot:matrix.org
this is the intended behaviour when the option to Sync Membership lists is enabled in the bridge, and it is for most of the bridges

This is about the GimpNET GIMPNet bridge.

@pksadiq pksadiq changed the title Remove IRC users from the user list when they quit Remove IRC users from the user list when they quit (GIMPnet network) Aug 28, 2017
@Mikaela Mikaela added the matrix.org-support Matrix.org specific problem possibly unrelated to the bridge label Aug 28, 2017
@Mikaela
Copy link
Contributor

Mikaela commented Aug 28, 2017

I didn't understand, do you mean that the issue is only at GIMPNet and the membership syncing isn't enabled there? Or do you mean that nick changes create ghost users which would make this a duplicate of #71 ?

I am not using the GIMPNet bridge.

(EDIT: fixed spelling of GIMPNet.)

@t3chguy
Copy link
Member

t3chguy commented Aug 28, 2017

from the description I got in #riot:matrix.org I'm led to believe the GimpNET GIMPNet bridge is not syncing parts/quits (membership list syncing)

@Mikaela Mikaela changed the title Remove IRC users from the user list when they quit (GIMPnet network) Enable membership syncing on GIMPNet Aug 28, 2017
@Mikaela
Copy link
Contributor

Mikaela commented Aug 28, 2017

Thanks, I adjusted the title (and was notified of incorrect spelling of GIMPNet).

@t3chguy
Copy link
Member

t3chguy commented Aug 28, 2017

thanks for the pointer, I wrote it wrong twice :L

@kegsay
Copy link
Member

kegsay commented Aug 29, 2017

This bridge already has membership syncing enabled. Based on the nicks given in this issue, I believe this is a dupe of #71. Closing.

@kegsay kegsay closed this as completed Aug 29, 2017
@pksadiq
Copy link
Author

pksadiq commented Aug 29, 2017

I tried to understand what would be causing this. And now I doubt if it is a IRC client issue. Most of the gnome users use Polari as IRC client.

So here is what I did:

  1. I used Emacs erc client (with nick 'sadiqA') and joined #gnome-hackers in GIMPNet
  2. Also used Polari (with nick 'sadiqB') and joined #gnome-hackers
  3. Then I quit from both the clients.

And the result is: user 'sadiqA' is marked as quit. But no information about 'sadiqB'. That is the nick sadiqB is still considered as connected (in RIOT web client)

join-irc

Further investigation shows that, once the nick 'sadiqB' is quit from Polari, I get no nick completion for 'sadiqB' in GNU Emacs erc client. But I get nick completion in RIOT web.

And this was happening in Freenode network too. This was why I filed the bug not specific to GIMPNet. Hope I have tracked down the issue.

Even though it is a Polari IRC client issue, as Emacs erc client can understand that the user have quit, I believe that Matrix can too.

Do I need to file a new bug for this?

@kegsay
Copy link
Member

kegsay commented Aug 29, 2017

Oh, that's interesting in a horrifying kind of way. How exactly are Polari clients leaving channels? The bridge listens for QUIT and PART and will map that to a leave event.

@pksadiq
Copy link
Author

pksadiq commented Aug 29, 2017

This is the message I get in Emacs when the Polari user quits:

*** sadiqB ([email protected]) has quit: Input/output error [18:34]

@afranke
Copy link

afranke commented Aug 29, 2017

Most of the gnome users use Polari as IRC client.

[citation needed] as I know many people on GIMPNet that use anything but Polari, and when I ask around for someone using it to do some tests I get crickets. Also Polari is known to have issues (#382) on its own.

@kegsay
Copy link
Member

kegsay commented Aug 29, 2017

has quit: Input/output error

I wonder if node-irc is representing this as an ERROR or something instead? Would need to investigate this with trace logging on the bridge.

@kegsay kegsay reopened this Aug 29, 2017
@kegsay kegsay changed the title Enable membership syncing on GIMPNet "NickName has quit: Input/output error" do not get mapped to leave events Aug 29, 2017
@kegsay kegsay added bug needs-investigation and removed matrix.org-support Matrix.org specific problem possibly unrelated to the bridge labels Aug 29, 2017
@pksadiq
Copy link
Author

pksadiq commented Aug 29, 2017

[citation needed]

That was an exaggeration. But the user base can be quite large. We don't need to have a fight on this. Do we? 😆

@justinbot justinbot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. and removed bug labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-investigation T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

6 participants