Skip to content

Implement correct Display trait for zksolc Error #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jrigada opened this issue Oct 28, 2024 · 0 comments · Fixed by #898
Closed

Implement correct Display trait for zksolc Error #643

Jrigada opened this issue Oct 28, 2024 · 0 comments · Fixed by #898
Assignees
@MBerguer
Labels
compiler 📟 Issues specific to compiling feature ➕ Feature item Internal ⚙️ needs triage ♟️ Issue needs to be picked up or assigned p2 🟡 Indicates moderately high priority item
Milestone
O.R Q1

Comments

@Jrigada
Copy link
Contributor

Jrigada commented Oct 28, 2024

Component

Other (please describe)

Describe the feature you would like

Zksolc and solc are a bit different in what they write to errors. Currently the display trait (which is what ends up being used to display the error to the user) was copied from solc and some things commented out to try to display something that makes sense. However, we should analyze the differences in outputs well and have a proper implementation for the trait given those differences.

Additional context

No response
@Jrigada Jrigada added compiler 📟 Issues specific to compiling feature ➕ Feature item needs triage ♟️ Issue needs to be picked up or assigned p2 🟡 Indicates moderately high priority item labels Oct 28, 2024
@Jrigada Jrigada moved this to Todo in DevEx squad Oct 28, 2024
@Jrigada Jrigada added this to the O.R Q1 milestone Jan 21, 2025
@MBerguer MBerguer self-assigned this Jan 29, 2025
@MBerguer MBerguer moved this from Todo to In Progress in DevEx squad Jan 29, 2025
@MBerguer MBerguer mentioned this issue Feb 4, 2025
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in DevEx squad Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBerguer MBerguer

Labels
compiler 📟 Issues specific to compiling feature ➕ Feature item Internal ⚙️ needs triage ♟️ Issue needs to be picked up or assigned p2 🟡 Indicates moderately high priority item
Projects
DevEx squad
Status: Done
Milestone
O.R Q1
Development

Successfully merging a pull request may close this issue.

feat: Improve display format matter-labs/foundry-zksync
2 participants
@MBerguer @Jrigada