Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement correct Display trait for zksolc Error #643

Open
Jrigada opened this issue Oct 28, 2024 · 0 comments
Open

Implement correct Display trait for zksolc Error #643

Jrigada opened this issue Oct 28, 2024 · 0 comments
Labels
compiler 📟 Issues specific to compiling feature ➕ Feature item Internal ⚙️ needs triage ♟️ Issue needs to be picked up or assigned p2 🟡 Indicates moderately high priority item

Comments

@Jrigada
Copy link
Contributor

Jrigada commented Oct 28, 2024

Component

Other (please describe)

Describe the feature you would like

Zksolc and solc are a bit different in what they write to errors. Currently the display trait (which is what ends up being used to display the error to the user) was copied from solc and some things commented out to try to display something that makes sense. However, we should analyze the differences in outputs well and have a proper implementation for the trait given those differences.

Additional context

No response
@Jrigada Jrigada added compiler 📟 Issues specific to compiling feature ➕ Feature item needs triage ♟️ Issue needs to be picked up or assigned p2 🟡 Indicates moderately high priority item labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler 📟 Issues specific to compiling feature ➕ Feature item Internal ⚙️ needs triage ♟️ Issue needs to be picked up or assigned p2 🟡 Indicates moderately high priority item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jrigada