Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new parameters of vm.ExpectRevert cheatcode #834

Open
Jrigada opened this issue Jan 9, 2025 · 0 comments
Open

Add support for new parameters of vm.ExpectRevert cheatcode #834

Jrigada opened this issue Jan 9, 2025 · 0 comments
Labels
cheatcode 🎮 Issue with a cheat code against zksync feature ➕ Feature item Internal ⚙️ p2 🟡 Indicates moderately high priority item upstream-parity 🟰 Needed for upstream feature parity

Comments

@Jrigada
Copy link
Contributor

Jrigada commented Jan 9, 2025

Component

Forge

Describe the feature you would like

Foundry introduced this new variations of expectRevert which are failing in zksync when doing nested calls.

  • vm.expectRevert(address reverter)
  • vm.expectRevert(bytes4 revertData, address reverter)
  • vm.expectRevert(bytes calldata revertData, address reverter)
    Test

Additional context

No response
@Jrigada Jrigada added cheatcode 🎮 Issue with a cheat code against zksync feature ➕ Feature item p2 🟡 Indicates moderately high priority item Internal ⚙️ upstream-parity 🟰 Needed for upstream feature parity labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cheatcode 🎮 Issue with a cheat code against zksync feature ➕ Feature item Internal ⚙️ p2 🟡 Indicates moderately high priority item upstream-parity 🟰 Needed for upstream feature parity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jrigada