Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only id supported? #1

Closed
gobbedy opened this issue Feb 1, 2021 · 3 comments
Closed

only id supported? #1

gobbedy opened this issue Feb 1, 2021 · 3 comments
Labels
feature request A feature request for future enhancements

Comments

@gobbedy
Copy link

gobbedy commented Feb 1, 2021 •
edited
Loading

Looks great!

From the readme, am I to understand that the search_submissions method only supports the ids parameter?
@mattpodolak
Copy link
Owner

mattpodolak commented Feb 1, 2021 •
edited
Loading

Hi @gobbedy , currently only the ids parameter is supported for search_submissions.

v0.1.0 is being released this week which will include the full functionality for this method (still not including aggs though)

@gobbedy
Copy link
Author

gobbedy commented Feb 1, 2021

@mattpodolak that's awesome! then i may be your first user for v0.1.0

@mattpodolak mattpodolak added the feature request A feature request for future enhancements label Feb 5, 2021
@mattpodolak
Copy link
Owner

Hi @gobbedy, I'm closing this ticket as v0.1.0 was released today which includes non-id based search for comments and submissions. Please open another ticket if you have any issues or feature requests.

@mattpodolak mattpodolak mentioned this issue Apr 21, 2021
Open
mattpodolak pushed a commit that referenced this issue Dec 21, 2022
@eddvrs
Pushshift updates (#1)
f678f2d 
* Update parameter names to match new API params

* Update reading of total_available after changes to response json structure

* Update checks on meta_data returned for batching requests

* Update gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request A feature request for future enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattpodolak @gobbedy