Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'api.search_submission_comment_ids' function only returns one comment id for a post with multiple comments #9

Closed
jingjieli95 opened this issue Mar 5, 2021 · 3 comments · Fixed by #10
Assignees

Comments

@jingjieli95
Copy link

Hi!

I have been trying pmaw to request pushshift reddit data. I am trying to get all the comment ids given a post/submission id using api.search_submission_comment_ids. An example of my code is:

list_id = ['6uey5x'] 
comment = api.search_submission_comment_ids(ids=list_id)

However, it only returns one comment id from this requested submission id: ['dls663o']. The request should have returned multiple comment ids according to the pushshift api: https://api.pushshift.io/reddit/submission/comment_ids/6uey5x

I also tried configuring the available options like memsafe, which didn't help. Interestingly, if I try to repeat the post id in the input, such as:

list_id = ['6uey5x', '6uey5x', '6uey5x', '6uey5x'] 
comment = api.search_submission_comment_ids(ids=list_id)

It gives more comment ids from the corresponding post: ['dls663o', 'dls67q6', 'dls6fgv', 'dls6fqj'].

Could you help look into it? I feel like this workaround might have not fully utilized the pipeline.

I really apprecaite your effort and this great tool!

@jingjieli95 jingjieli95 changed the title 'api.search_submission_comment_ids' function only returns one comment id for a post with multiple comment 'api.search_submission_comment_ids' function only returns one comment id for a post with multiple comments Mar 5, 2021
@mattpodolak
Copy link
Owner

Hi @jingjieli95 thanks for opening this issue, I'll look into this

@mattpodolak mattpodolak self-assigned this Mar 5, 2021
@mattpodolak
Copy link
Owner

I found the issue, this is due to a limit miscalculation for ids. I'll push out a fix in an hour or so

@mattpodolak
Copy link
Owner

Closed this issue as this has been fixed in v1.0.4, please open another issue if you run into any problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants