Faint colors missing for Konsole?

[JOJ0]

Hi, awesome collection of themes. I got to know your repo for the iTerm2 themes. Recenctly I'm more using my Linux laptop for daily work and would like to use my beloved "Tomorrow Night Eighties" theme in Konsole.

I realized that the "faint" versions of all 8 colors are missing in the .colorscheme for konsole. I then investigated to find out that a lot of themes are missing the "faint" version of the colors.

Is there a general approach to fix this or would we need to fix each and every theme manually?

[mbadolato]

I don't know anything about the konsole ports, but I would assume it's one of two things. Either konsole doesn't support them, or the converter from the xrdb to konsole format has an issue with those conversions. If it's a converter issue, and someone is able to fix it, running the converted again should update the themes to fix them all

[JOJ0]

I had a look in the rendered Konsole files, the "faint" colors are definitely missing. So it seems to be the latter issue you are describing. If you give me a pointer where this xrdb thing "lives" I can give it a try. I actually I don't have much idea of theming and rely on the pro's for stuff like that, but yeah...I can still try and learn... :-)

[JOJ0]

Here's an example, usually we would have 3 stanzas: color, colorIntense and colorFaint, we see that the last one is missing:

[Color0]
Color=0,0,0

[Color1]
Color=242,119,122

[Color2Intense]
Color=153,204,153

[Color3Intense]
Color=255,204,102

[Color4Intense]
Color=102,153,204

[Color5Intense]
Color=204,153,204

[Color6Intense]
Color=102,204,204

[Color7Intense]
Color=255,255,255

[Color2]
Color=153,204,153

[Color3]
Color=255,204,102

[Color4]
Color=102,153,204

[Color5]
Color=204,153,204

[Color6]
Color=102,204,204

[Color7]
Color=255,255,255

[Color0Intense]
Color=0,0,0

[Color1Intense]
Color=242,119,122

If I add it manually via the Konsole GUI settings, I would additionally get things like that for each color:

[Color1Faint]
Color=242,119,122

[mbadolato]

All of the converters etc were not created by me so I don't have a lot of idea about how they work.

But the main converter is at
https://github.com/mbadolato/iTerm2-Color-Schemes/blob/master/tools/converter.py

The template for konsole is in the templates directory is at:
https://github.com/mbadolato/iTerm2-Color-Schemes/blob/master/tools/templates/konsole.colorscheme

[jdhmtl]

@JOJ0 Looking at your example, it appears that all three stanzas have the same values. If that's the case, this should be a relatively simple fix.

[JOJ0]

@jdhmtl ? maybe there is a misunderstanding. yeah i fixed it manually already. The actual question was: why are faint colors not existing in the konsole schemes at all?

[JOJ0]

But thanks for the reminder that I opened this issue anyway. The very kast link @mbadolato posted reveals the root cause: [ColorXFaint] stanzas are simply missing in the template for Konsole schemes.

[tehaleph]

@JOJ0 Thank you for noticing this bug, I've never used Konsole, so when I rewrote the templating system, I just took the old version of Konsole template and didn't really dig into it.

@mbadolato I think I can prepare PR with color desaturation logic. In my mind this would be better than just duplication, although it may lead to undefined side effects in some themes.