Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add checks on valid_on to read methods #252

Open
HomoCodens opened this issue Jan 24, 2022 · 1 comment
Open

add checks on valid_on to read methods #252

HomoCodens opened this issue Jan 24, 2022 · 1 comment
Assignees
@HomoCodens

Comments

@HomoCodens
Copy link
Collaborator

valid_on must be a vector of length 1 that is either a Date or an yyyy-mm-dd string.

How would we best/most elegantly enforce this?
@HomoCodens HomoCodens self-assigned this Jan 24, 2022
@HomoCodens
Copy link
Collaborator Author

Actually, it may now have to be a Date at least when it is passed to dbQuoteLiteral. See #250.

Currently it is documented thusly:

#' @param valid_on \strong{character} representation of a date in the form of 'YYYY-MM-DD'. valid_on selects the
#' version of a time series that is valid at the specified time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HomoCodens HomoCodens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HomoCodens