You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi - thanks for this library! We're using it for IBAN validation.
While reviewing the dependencies pulled in by this library, I noticed that both iso3166 and pycountry are added. As far as I can tell, both libraries ship the alpha 2 and alpha 3 country codes and that appears to be how they are used in this library.
If this observation is correct, perhaps one of the dependencies could be dropped (probably drop the one that's used the least)?
Of course, I might be missing something here, but if it could be an oversight, I can draw up a PR.
In case I'm plain wrong and there's a deliberate reason that I missed, I understand if you simply close this question :)
The text was updated successfully, but these errors were encountered:
Hi - thanks for this library! We're using it for IBAN validation.
While reviewing the dependencies pulled in by this library, I noticed that both iso3166 and pycountry are added. As far as I can tell, both libraries ship the alpha 2 and alpha 3 country codes and that appears to be how they are used in this library.
If this observation is correct, perhaps one of the dependencies could be dropped (probably drop the one that's used the least)?
Of course, I might be missing something here, but if it could be an oversight, I can draw up a PR.
In case I'm plain wrong and there's a deliberate reason that I missed, I understand if you simply close this question :)
The text was updated successfully, but these errors were encountered: