Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the iso3166 and pycountry dependencies doing the same thing? #200

Closed
sergei-maertens opened this issue Apr 30, 2024 · 3 comments
Closed

Comments

@sergei-maertens
Copy link

Hi - thanks for this library! We're using it for IBAN validation.

While reviewing the dependencies pulled in by this library, I noticed that both iso3166 and pycountry are added. As far as I can tell, both libraries ship the alpha 2 and alpha 3 country codes and that appears to be how they are used in this library.

If this observation is correct, perhaps one of the dependencies could be dropped (probably drop the one that's used the least)?

Of course, I might be missing something here, but if it could be an oversight, I can draw up a PR.

In case I'm plain wrong and there's a deliberate reason that I missed, I understand if you simply close this question :)

@mdomke
Copy link
Owner

mdomke commented May 7, 2024

Hej @sergei-maertens,
you are completely right. I will remove the iso3166-library from the dependencies. Thanks for the heads-up.

@mdomke
Copy link
Owner

mdomke commented May 7, 2024

The iso3166-dependency has been removed in release 2024.05.0

@mdomke mdomke closed this as completed May 7, 2024
@sergei-maertens
Copy link
Author

Awesome, thanks for the quick follow up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants