Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering elevation for Salah times #27

Open
Raviu56 opened this issue Feb 22, 2023 · 7 comments
Open

Considering elevation for Salah times #27

Raviu56 opened this issue Feb 22, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@Raviu56
Copy link

Raviu56 commented Feb 22, 2023

Assalamo alaykom,
Jazakum Allahu khayran for your application.

There is one problem that most Prayer times app does not take into account which is Altitude/elevation above sea level of the location point.
This is really a big problem and can make difference of minutes of prayer time. The app assumes everything is at sea level which is not the case usually.
Consider those 2 locations:

36.34444/30.12013/~35m
36.33877/30.05053/~1650m

Distance between them is around 6300m while elevation difference is over 1600m which diffidently should have much effect on prayer time.

You can watch this video in Arabic language

https://www.youtube.com/watch?v=yIaVmmRXLcI

I think you should seek help from https://www.astronomycenter.net/ on how to take elevations into account

@Raviu56
Copy link
Author

Raviu56 commented Feb 22, 2023

Check this application it's for Sunrise and Sunset time calculations. Its default calculation method called time4a-time4j takes elevation into account and you can with simple click turn on/off elevation and see how much it affects Sunrise/Sunset times . You can make use of its code too

https://github.com/forrestguice/SuntimesWidget

@meypod
Copy link
Owner

meypod commented Feb 23, 2023

Va alaykum assalam,
Thanks for bringing this up
To address this we need to address it in the library this app uses:
https://github.com/batoulapps/adhan-js

@meypod meypod closed this as completed Feb 23, 2023
@meypod meypod reopened this Feb 23, 2023
@meypod meypod added the bug Something isn't working label Feb 23, 2023
@meypod
Copy link
Owner

meypod commented Feb 23, 2023

I'll make an issue there, and discuss it with them

@meypod
Copy link
Owner

meypod commented Feb 23, 2023

Hi @Raviu56
please take a look at these:
batoulapps/adhan-js#126 (comment)
batoulapps/adhan-js#16 (comment)

from what it seems, it does not seem to be an easily solvable issue

@meypod
Copy link
Owner

meypod commented Feb 23, 2023

so the affected times are : Fajr, sunrise, sunset, maghrib, isha

@Raviu56
Copy link
Author

Raviu56 commented Feb 23, 2023

Yes,
For Fajr and Isha effect is minimal as in the videos. But for Fajr limit of Sunrise and Maghrib there is a considerable effect.

I've opened a new issue there

batoulapps/adhan-js#146

@meypod
Copy link
Owner

meypod commented Feb 23, 2023

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants