Skip to content

Latest commit

 

History

History
 
 

integration

Folders and files

NameName
Last commit message
Last commit date

parent directory

..
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Integration tests

The goal of these tests is to run Sails just like you or I would, and verify that no anomolies have been introduced in general.

This is a great place to jump in if you're interested in contributing code to Sails core!

How Can I Help?

We could use your help writing more integration tests that test Sails under specific conditions.

Integration tests for each core hook

When writing an integration tests that verifies the behavior of a particular hook, the following assertions should be made:

  1. Did the hook's default config make it into sails.config?
  2. Did sails.load work as expected with the hook enabled and all the hooks it depends on enabled?
  3. Did sails.lift work as expected with the hook enabled and all the hooks it depends on enabled?
  4. Post-sails.load, is the process/application state correct? (i.e. did the hook do what it was supposed to do?)
  5. Did the hook do what it was supposed to do after tearing down the server using sails.lower()?

Integration tests for the hook loader

We could really use more tests for the following cases:

  1. If we sails.load using loadHooks to allow only specific hooks, or hooks to disable particular hooks, only the specified hooks should actually be loaded.
  2. sails.load() should fail if a test tries to load a hook that depends on other hooks, but those other hooks are disabled. Note that sails.load should fail with a relevant error message and should not hang in this case.