Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch of timeout unit in doc and example code #1135

Open
ramonqu7 opened this issue Mar 29, 2023 · 0 comments
Open

Mismatch of timeout unit in doc and example code #1135

ramonqu7 opened this issue Mar 29, 2023 · 0 comments

Comments

@ramonqu7
Copy link

I noticed there is a mismatch with the time unit of the timeout between sample code comment and doc, can someone from the team to confirm on the unit?

In the doc:
https://learn.microsoft.com/en-us/sql/linux/sql-server-linux-backup-vdi-specification?view=sql-server-ver16#clientvirtualdevicegetcommand

int ClientVirtualDevice::GetCommand (
time_t	 	timeout,	// time-out in milliseconds
VDC_Command**	ppCmd	// returns the next command
);

However in the comment it said as seconds.

// Timeout in seconds
//
int timeout = 90;
while ((status = vd->GetCommand(timeout, &cmd)) == 0)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant