Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import-xlf command should output package.nls.[language].json loc files to root, not --output-dir #164

Open
jruales opened this issue Apr 4, 2024 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug @vscode/l10n-dev
Milestone

Comments

@jruales
Copy link
Contributor

jruales commented Apr 4, 2024

In @vscode/l10n-dev, the import-xlf command takes a parameter --output-dir, which per the current logic sets the output directory for both bundle.[language].json and package.nls.[language].json.

However, this doesn't accommodate the case from the official l10n-sample, where you can see that the file package.nls.[language].json lives in the root directory, whereas the file bundle.[language].json lives in the ./l10n/ directory. From what I understand, the package.nls.[language].json files must live in the same directory as package.nls.json and package.json, regardless of the value of the l10n parameter specified inside of package.json, so why does import-xlf move package.nls.[language].json to a folder where it won't be recognized?

@TylerLeonhardt
Copy link
Member

Yeah these should just go to wherever the package.json is.

@TylerLeonhardt TylerLeonhardt self-assigned this Apr 4, 2024
@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug @vscode/l10n-dev labels Apr 4, 2024
@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug @vscode/l10n-dev
Projects
None yet
Development

No branches or pull requests

2 participants