Fix type inference of non-integer numbers (tediousjs#475)

Also included test against getTypeByValue to simplify future type inference confirmations
mikereams · May 17, 2017 · 2f59a23 · 2f59a23
1 parent d542c4a
commit 2f59a23
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/lib/base.js b/lib/base.js
@@ -66,14 +66,12 @@ let getTypeByValue = function (value) {
       return TYPES.NVarChar
 
     case 'number':
-      for (item of Array.from(map)) {
-        if (item.js === Number) {
-          return item.sql
-        }
+      if (value % 1 === 0) {
+        return TYPES.Int
+      } else {
+        return TYPES.Float
       }
 
-      return TYPES.Int
-
     case 'boolean':
       for (item of Array.from(map)) {
         if (item.js === Boolean) {
@@ -1558,7 +1556,8 @@ module.exports = {
     ISOLATION_LEVEL,
     TYPES,
     MAX: 65535, // (1 << 16) - 1
-    map
+    map,
+    getTypeByValue
   }
 }
 

diff --git a/test/common/unit.js b/test/common/unit.js
@@ -173,4 +173,9 @@ describe('Unit', () => {
       done()
     })
   })
+
+  it('infer type by value', () => {
+    assert.strictEqual(sql.Int, sql.getTypeByValue(23))
+    assert.strictEqual(sql.Float, sql.getTypeByValue(1.23))
+  })
 })