Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the openstack icons don't render properly #497

Closed
lrjball opened this issue Mar 29, 2021 · 0 comments · Fixed by #498
Closed

Some of the openstack icons don't render properly #497

lrjball opened this issue Mar 29, 2021 · 0 comments · Fixed by #498

Comments

@lrjball
Copy link
Contributor

lrjball commented Mar 29, 2021

Some of the openstack icons currently don't work as expected. This looks to be because the code to generate the _icon_dir assumes the directories under each provider contain all of the pngs, and don't themselves contain any directories. For some of the openstack icons the pngs are too nested so one of the directories gets missed off the _icon_dir, leading to the png not being found.

For example, diagrams.openstack.deployment.Chef does not currently work and neither do the other icons in that folder, as well as a few other folders. I think the easiest fix is to just remove the excessive nested, so will put in a PR for that shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant