Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve template compilation #2997

Open
jvoisin opened this issue Dec 9, 2024 · 1 comment
Open

Improve template compilation #2997

jvoisin opened this issue Dec 9, 2024 · 1 comment
Assignees
@jvoisin
Labels
change proposal

Comments

@jvoisin
Copy link
Collaborator

jvoisin commented Dec 9, 2024

In internal/template/engine.go, templates are read in memory and parsed. It would be better to make use of the ParseFS function, and to re-use the common templates via commonTemplates.Parse instead of concatenating everything manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvoisin jvoisin

Labels
change proposal
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fguillot @jvoisin and others