Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhoneNumberValidatorTest fails on CI #205

Open
Nek- opened this issue Aug 1, 2019 · 1 comment
Open

PhoneNumberValidatorTest fails on CI #205

Nek- opened this issue Aug 1, 2019 · 1 comment

Comments

@Nek-
Copy link

Nek- commented Aug 1, 2019

Why? Because the phone number +448431234567 is no more "shared cost" categorized.

How to fix?

  1. Remove the line 140
  2. Find a new share cost number (after a few google on the topic, can't find one)
@Nek- Nek- mentioned this issue Aug 1, 2019
Open
@maxhelias maxhelias mentioned this issue Aug 1, 2019
Closed
@maxhelias
Copy link

You have also a error on this line for Sf < 3.0 :
https://github.com/misd-service-development/phone-number-bundle/blob/master/Tests/Form/Type/PhoneNumberTypeTest.php#L224

But I think we can drop the support up to version 3.4

@maxhelias maxhelias mentioned this issue Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make travis happy again
2 participants
@Nek- @maxhelias