Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile is good #7

Closed
alexmyczko opened this issue Apr 12, 2023 · 4 comments
Closed

Makefile is good #7

alexmyczko opened this issue Apr 12, 2023 · 4 comments

Comments

@alexmyczko
Copy link

... but the dependency on must use venv not so much. Quickly looking at the Makefile, it should be possible to
build the font without venv from source. Would you accept such patches? (Asking because well then I might want to create a Debian package of the font)

@mishamyrt
Copy link
Owner

If you can make a build system that can do all the same things (hardcoding features, substituting ligatures at build time, etc.) then sure, I would be glad.

@alexmyczko
Copy link
Author

alexmyczko commented Apr 14, 2023

Ok looking at http://sid.ethz.ch/debian/fonts-lilex/fonts-lilex-2.100/requirements.txt

We're (for Debian unstable) stuck at:

fontmake==3.5.1    (only have 2.4.1)
cu2qu==1.6.7       (n/a)
gftools==0.9.27    (only have 0.5.2)
glyphsLib==6.2.1   (only have 6.0.6)
arrrgs==2.0.0      (n/a)
# ruff==0.0.259      (n/a)
# pylint==2.17.1     (only have 2.16.2)

after some pip3 install n/a pkgs --break-system-packages

I can manually run
$ python scripts/lilex.py build
and watch it do things
and see the message
☺️ Font binaries successfully builded # should be built not builded

@mishamyrt
Copy link
Owner

mishamyrt commented Apr 14, 2023

I don't really want to be stuck with old versions just because they aren't available on Debian Unstable. Can we have a separate requirements.deb.txt for that? Also, we could remove ruff and pylint from there, which aren't needed for the build.

And add another workflow to make sure the build still works and that I didn't break it by adding new features.

@alexmyczko
Copy link
Author

Don't worry, a requirements.deb.txt is not needed, up to debian maintainer to solve it. But the hint ruff+pylint not needed for build is helpful indeed. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants