Crash when minimising waveforms section

[RadioDM]

Bug Description

Steps to reproduce

1. Load any track(s) in any deck(s). edit(@ronso0): a marker must be visible in the waveform (eg. a hotcue, with Cue alone it won't crash)
2. Grab the bottom edge of parallel waveforms section with mouse click, drag to top to minimise it.
3. Mixxx instantly hang and then crash. Every time

I can enlarge the section and then make it smaller back with no issue. But dragging the edge up to the point it would disappear cause the bug.

This was first spotted on 2.4.1. Updated to 2.4.2 to still get the bug. Updated to 2.5.0 and the bug is still there.

Related settings:
Skin: Deere, 4 decks, Waveform type: Filtered (GLSL)

Version

2.5.0

OS

Windows 10 Pro 22H2

[ronso0]

Uff, sounds bad.

Please create a backtrace (here's how to) and also provide a log file of the crashing session (here's how to find it).
Which skin and which waveform type do you use?

[Toneplay]

Could not reproduce on my Windows 11 Machine. (Skin: Deere, 4 decks, Waveform type: Filtered (GLSL))

[RadioDM]

Related settings:
Skin: Deere, both 2 and 4 decks, Waveform type: Filtered (GLSL)

Attaching log and backtrace.
bug backtrace 1 - waveform disappear.txt
mixxx - (1).log

[ronso0]

Thank you!
Can you reproduce the crash with other skins?

[ronso0]

Also, can you maximize the library?

[RadioDM]

Yes, I can maximise library (has it always still showed small decks on top? maybe something changed. Thats not important)

[RadioDM]

Skins with no crash

Skins where dragging will not minimise/hide parallel waveforms, can resize but not hide. And the Waveforms (on/off) button works well:

• late night palemoon
• late night classic
• Tango

Skin with no parallel waveforms, no problems:

• shade classic

Skins where crash is possible:

• Deere 64 samplers - sometimes crash.
  There is no way to minimise it with drag. Resizing waveforms is very limited (no idea if intentional - no library seen as well). It can be either:
  a) of height exactly as 2 decks one of top of each other
  b) or I can maximise it.
  But on the Skin UI settings (cog top right corner), when I disable Paralell Waveforms it may crash, may not. Cannot find a path to reproduce everytime.

• Deere - Always crash.
  Even in instance where I couldn't crash Deere 64 samplers by disabling/enabling waveforms, for several times, and I changed back to normal Deere and pulled of crash straight after first time trying to minimise Wave

[daschuer]

I think it is crashing here:
https://github.com/qt/qtbase/blob/372eaedc5b8c771c46acc4c96e91bbade4ca3624/src/opengl/qopengltexture.cpp#L213

mixxx/src/waveform/renderers/allshader/waveformrendermark.cpp

Line 133 in a807be6

texture->bind();

[daschuer]

@RadioDM pleas try out #14170 This fixes the crash for me.

[RadioDM]

I confirm it is fixed with the PR mentioned. GJ